Ensembl / WiggleTools

Basic operations on the space of numerical functions defined on the genome using lazy evaluators for flexibility and efficiency
Apache License 2.0
144 stars 25 forks source link

output of CV iterator #20

Closed ChiWPak closed 6 years ago

ChiWPak commented 7 years ago

Obtaining unexpected output using the CV function

chr1 0 249239823 nan chr10 0 135499788 nan chr11 0 134946510 nan chr12 0 133833357 nan chr13 0 115084925 nan etc...

Using the same set of input files, but with the sum function, I obtain expected results chr1 0 10444 0.000000 chr1 10444 10609 0.043840 chr1 10609 13296 0.000000 chr1 13296 13461 0.043840 chr1 13461 17353 0.000000 chr1 17353 17517 0.043400 etc...

Do I need to fill in default values? Or is this a bug?

dzerbino commented 6 years ago

Hello @ChiWPak,

Apologies for the slow reply.

How could I reproduce this bug?

Daniel

ChiWPak commented 6 years ago

Hi Daniel,

Sorry but I'm experiencing issues with my computer which won't be fixed for 3-5 days. Waiting for a part. Once it's fixed I'll try to forward you a small reproducible example. (I'm on mobile)

Chi

On Friday, January 5, 2018, Daniel Zerbino notifications@github.com wrote:

Hello @ChiWPak https://github.com/chiwpak,

Apologies for the slow reply.

How could I reproduce this bug?

Daniel

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Ensembl/WiggleTools/issues/20#issuecomment-355563793, or mute the thread https://github.com/notifications/unsubscribe-auth/AQn1wuJbeGJKlRiLLgXsHtoGSzDx88N_ks5tHi3hgaJpZM4QRSBt .

ChiWPak commented 6 years ago

Sorry again for the delay...

Here are the commands I'm running

wiggletools write out_sum.txt sum fi1.bw fi2.bw

wiggletools write out_CV.txt CV fi1.bw fi2.bw

The bigwig files I'm using are >1 GB, but if you cannot reproduce the issue with some BW files of your own, I'll attempt to make smaller BW files to share with you that recreate the issue.

Thanks, Chi

On Fri, Jan 5, 2018 at 8:12 AM, Daniel Zerbino notifications@github.com wrote:

Hello @ChiWPak https://github.com/chiwpak,

Apologies for the slow reply.

How could I reproduce this bug?

Daniel

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Ensembl/WiggleTools/issues/20#issuecomment-355563793, or mute the thread https://github.com/notifications/unsubscribe-auth/AQn1wuJbeGJKlRiLLgXsHtoGSzDx88N_ks5tHi3hgaJpZM4QRSBt .

dzerbino commented 6 years ago

OK, I can reproduce it, I'll have a look sometime next week.

dzerbino commented 6 years ago

What do you know, a meeting was cancelled and the bug was embarrassingly trivial, fixed on master.

ChiWPak commented 6 years ago

That's good news! Thanks!

On Fri, Jan 12, 2018 at 3:34 AM, Daniel Zerbino notifications@github.com wrote:

What do you know, a meeting was cancelled and the bug was embarrassingly trivial, fixed on master.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Ensembl/WiggleTools/issues/20#issuecomment-357188884, or mute the thread https://github.com/notifications/unsubscribe-auth/AQn1whkiVoW6C_s2ozvH9vFdsPWKW3pjks5tJycpgaJpZM4QRSBt .