search

Ensembl / WiggleTools

Basic operations on the space of numerical functions defined on the genome using lazy evaluators for flexibility and efficiency
Apache License 2.0
144 stars 25 forks source link

Implementation for toInt #32

Closed joshuak94 closed 5 years ago

joshuak94 commented 5 years ago

Instead of using floor, which is more expensive, a static cast toInt will accomplish the same thing.

dzerbino commented 5 years ago

GitHub is complaining because you are modifying the very same lines of code as your previous PR.

Could you please rebase your toInt branch onto master? This should clean up this PR.

dzerbino commented 5 years ago

Your test could probe the functionality a bit more, e.g. wiggletools isZero diff variableStep.wig toInt offset 0.1 variableStep.wig

joshuak94 commented 5 years ago

Done! Also changed the tests for toInt and floor.