Ensembl / ensembl-vep

The Ensembl Variant Effect Predictor predicts the functional effects of genomic variants
https://www.ensembl.org/vep
Apache License 2.0
456 stars 152 forks source link

HGVS: Protein prediction empty for variants not in coding region #499

Closed ifokkema closed 1 month ago

ifokkema commented 5 years ago

The HGVSp field is empty for variants in the intron or in the UTR. The correct HGVS description for not expecting a change on protein level would actually be p.(=). In case the variant is inside a splice site region, you can use p.?.

https://varnomen.hgvs.org/recommendations/uncertain/

p.? used to indicate that an effect on the protein level is expected but that it is not possible to give a reliable prediction of the consequences

https://varnomen.hgvs.org/recommendations/RNA/variant/splicing/ (see: Q&A)

How can I best describe the predicted consequences at the protein level of a variant that most probably affects splicing? The best format seems to use "p.?", meaning "I do not know what to expect at the protein level".

dglemos commented 5 years ago

Hi @ifokkema, Thank you so much for your input. At the moment HGVSp is not provided if it's not in the protein but it's something we plan to implement in a future release.

Best regards, Diana

ifokkema commented 5 years ago

Hi @dglemos, thank you for your quick reply! In principle, the variant could still affect the protein in some cases, even though it's not in the CDS. Since the variant is located in the gene, providing a predicted effect on protein level is still recommended. The following are the rules as in place by LOVD, which are simply an implementation choice and just a suggestion, by far not perfect and not the only possible implementation.

dglemos commented 5 years ago

Thank you for the detailed examples, it's very helpful to us to know how HGVS is being implemented by different entities. We'll look into this and I'll let you know when a change is coming.

Thanks Diana

nakib103 commented 1 month ago

Hello @ifokkema,

We are not prioritising to add any new features to the current implementation of HGVS. Instead, we are looking to improve these cases in our future implementation of VEP.

Best regards, Nakib

ifokkema commented 2 weeks ago

Thank you for the update, @nakib103 ! Does that new implementation of VEP have a different repository where I can copy the feature request to, or do you plan to use pre-existing libraries such as VariantValidator?