search

EnsemblGSOC / Ensembl-Repeat-Identification

A Deep Learning repository for predicting the location and type of repeat sequence in genome.
4 stars 3 forks source link

missing arguments #42

Closed williamstark01 closed 1 year ago

williamstark01 commented 1 year ago

The "--configuration ..." line here needs to be uncommented as we started using the configuration file for training: https://github.com/yangtcai/Ensembl-Repeat-Identification/blob/d64307d335135a3637440eb7ae25d0814cc56160/submit_cluster_job.py#L72-L75

The iou_threshold parameter is missing in the function definition: https://github.com/yangtcai/Ensembl-Repeat-Identification/blob/d64307d335135a3637440eb7ae25d0814cc56160/train.py#L61-L68 as used here: https://github.com/yangtcai/Ensembl-Repeat-Identification/blob/d64307d335135a3637440eb7ae25d0814cc56160/train.py#L134-L142

yangtcai commented 1 year ago

Yes, I still have not push the local change to the repo, next week I will pay attention to our project.

williamstark01 commented 1 year ago

Alright, no worries until then. This can be a small commit on top of the latest PR.

yangtcai commented 1 year ago

I think the latest update has resolved this issue:D

williamstark01 commented 1 year ago

done in #41