EnsembleUI / ensemble

Build native apps 20x faster than Flutter, RN or any other tech
https://ensembleui.com/
BSD 3-Clause "New" or "Revised" License
117 stars 15 forks source link

Setting visible property of DataRow in code is not working as expected #640

Open anserwaseem opened 1 year ago

anserwaseem commented 1 year ago

Issue

Setting visible property of DataRow in code is not working as expected. Kindly run the given code to reproduce this issue.

Example Code

View:
  body:
    Column:
      children:
        - Button:
            label: Make row visible
            onTap:
              executeCode:
                body: |
                  //@code
                  myRow.visible = true;

        - Column:
            children:
              - DataGrid:
                  DataColumns:
                    - label: Hotel Name
                      type: text
                    - label: Location
                      type: text
                  children:
                    - DataRow:
                        children: 
                          - Text:
                              text: Hello
                          - Text:
                              text: Hello
                    - DataRow:
                        visible: false
                        id: myRow
                        children:
                          - Text:
                              text: Test
                          - Text:
                              text: Test
kmahmood74 commented 9 months ago

@hemish11 this breaks all DataGrids that use item-templates. With item-templates, _children can grow dynamically but rowVisibilities is a static array, will create a PR to comment out some code

kmahmood74 commented 8 months ago

@hemish11 is this still on or we've given up on it? it's not a high priority.