search

EnsoFinance / temper

Temper your expectations - Ethereum Transaction Simulator
MIT License
343 stars 43 forks source link

Formattrace - Huge impact on performance #13

Closed polyphia closed 1 year ago

polyphia commented 1 year ago

I'm not sure if this is expected behavior, but when benchmarking around 100 simulations of single txs I get the following results :

Without formattrace : 200 / 300 ms

With formattrace : 1.5-2.5 seconds

Is this normal ?

Also not sure why in the env file it says formattrace won't work without etherscan API key, I get the same formattrace format regardless if I use key or not .

devanoneth commented 1 year ago

It is definitely expected, formatting the trace requires quite a lot of extra computation and network requests. If you need speed, I'd recommend not formatting them.

Regarding the message in the .env.example, it's not exactly correct. What it should say is that the formatted traces will have more contract and function names if you include the Etherscan API key. Have you noticed this?

polyphia commented 1 year ago

Yes you're right I can see more function names when I activate it