EntEthAlliance / EthTrust-public

Apache License 2.0
0 stars 0 forks source link

Delete/Rephrase explanation of gas tokens #3

Closed gsalzer closed 3 months ago

gsalzer commented 4 months ago

Section 3.6 Gas and Gas Prices explains gas tokens as use Gas when minted and free slightly less Gas when burned. Gas Tokens minted when Gas prices are low can be burned to subsidize Ethereum transactions when Gas prices are high.

Is this still a relevant and accurate description, given that the gas refund for SELFDESTRUCT was removed with the London hard fork (August 2021) by enforcing EIP-3529?

Suggestion: either remove the paragraph entirely, or rephrase it to something like: "Gas Tokens use Gas when minted and free slightly less Gas when burned, provided the EVM refunds a sufficient quantity of Gas for clearing the state. Gas Tokens minted when Gas prices are low can be burned to subsidize Ethereum transactions when Gas prices are high. On Ethereum's main chain, Gas refunds where removed with the London hard fork that deployed EIP-3529.

chaals commented 3 months ago

@gsalzer Thank you for the feedback!

We propose to edit the text along the lines you suggest:

Gas Tokens use Gas when minted and free slightly less Gas when burned, provided the EVM refunds a sufficient quantity of Gas for clearing the state. Gas Tokens minted when Gas prices are low can be burned to subsidize Ethereum transactions when Gas prices are high. On Ethereum's main chain, Gas refunds were removed with the London hard fork that deployed [[EIP-3529]] in August 2021, effectively disabling Gas Tokens.

If you think we got this wrong, please let us know. The change will be reflected in the Editor's draft soon (in minutes, not days).

gsalzer commented 3 months ago

@chaals Thanks for processing my note. Two remarks:

chaals commented 3 months ago

@gsalzer I think (as a native english speaker) that "effectively disabling gas tokens" covers the meaning sufficiently well. However, if as a non-native speaker you think it would be helpful if the text were more precise, I'll make a further tweak. Please thumbs-up this comment if you would like me to do so - no need to reopen the issue as we're now talking about an editorial adjustment to a non-normative section.

gsalzer commented 3 months ago

@chaals Thanks, it's fine for me if it is for you.