search

Enteligenz / StardewMods

Collection of my Stardew Valley mods.
MIT License
1 stars 1 forks source link

GMCM Support? #3

Closed SocksTheWolf closed 2 months ago

SocksTheWolf commented 2 months ago

Would it be worthwhile to add in support for GMCM so that the mod can be configured via in game?

https://github.com/spacechase0/StardewValleyMods/tree/develop/GenericModConfigMenu#for-c-mod-authors

Enteligenz commented 2 months ago

Possibly, yea. I don't really use the mod myself so I don't know what users might prefer. Though obviously, at the very least the password should not be editable through the menu ;)

Enteligenz commented 2 months ago

Does it support lists though, such as for the IgnoredAccounts option? I can't really find it.

SocksTheWolf commented 2 months ago

could add a string field that is manually exploded and repacked that is space separated/csv!

SocksTheWolf commented 2 months ago

image

I quickly cooked up this which I'll push in a pull request. You can change the values of the bots that you don't want and it properly restores back into an array. Obviously, if the array is just , then you'll have invalid garbage in the array config, but there's no negative issues there.

I added a password page which is hidden by default and also does not show up in the game (only main menu) where one can put in the OAuth token.

This works, but obviously you would need to restart for any connection changes. However this does make it like a billion times easier for general purpose audiences.

Could also add localization as well.

Enteligenz commented 2 months ago

That looks amazing :) I'll test it myself in a bit and take a look at localization, at least that's something I have done before. Once more, thank you for your work!

Enteligenz commented 2 months ago

Ah, damn, you're quick. Just noticed you already threw in localization as a bonus. Well, I guess I can handle German localization :')

SocksTheWolf commented 2 months ago

The main major thing that could be done is to rework the initialization of TwitchBot to execute upon loading a save, rather than on initial entry into the application, allowing for the user to execute their config changes without a restart.

Maybe that's a task for a separate issue.

Enteligenz commented 2 months ago

Sounds reasonable, yea. I'll close this for now.

SocksTheWolf commented 2 months ago

I'll open a new issue for that.

SocksTheWolf commented 2 months ago

New issue in #5