Enter-tainer / typst-preview

[DEPRECATED] Use tinymist instead
https://Enter-tainer.github.io/typst-preview/
MIT License
444 stars 21 forks source link

View jumps when zooming #223

Closed Enivex closed 9 months ago

Enivex commented 10 months ago

When zooming in and out, the view occasionally jumps for a frame, making the experience feel stuttery

https://github.com/Enter-tainer/typst-preview/assets/2191754/b10ee51c-64a8-4023-b629-6a3fdd37191c

I believe it was introduced in 10.2.3, as I couldn't reproduce it in 10.2.2

joleeee commented 9 months ago

The most annoying part for me is that it's very hard to zoom to the desired level.

Maybe something to do with high resolution trackpad and not scaling raw values according to this? Just my gut feeling.

https://github.com/Enter-tainer/typst-preview/assets/24441708/1ae779bd-d0a5-4598-9ee7-9a0325d0edb4

Especially because there doesn't seem to be a keyboard shortcut for zooming (Ctrl +/- zooms entire vscode)

Enter-tainer commented 9 months ago

trackpad zoom experience is getting improved in #244 . Would you like download a ci built version and have a try? You can scroll to the end of https://github.com/Enter-tainer/typst-preview/actions/runs/7868327586 and select the vsix file for your platform

joleeee commented 9 months ago

Now the zoom direction is reversed! I pinch and it zooms out! Other than that it is a bit "glitchy", but it's better :)

https://github.com/Enter-tainer/typst-preview/assets/24441708/f101a752-8c66-49ba-a81f-dae9b327a879

Enter-tainer commented 9 months ago

Now the zoom direction is reversed! I pinch and it zooms out! Other than that it is a bit "glitchy", but it's better :)

https://github.com/Enter-tainer/typst-preview/assets/24441708/f101a752-8c66-49ba-a81f-dae9b327a879

reverse is not desired! i will fix it

joleeee commented 9 months ago

This is fixed now I think and can be closed @Enter-tainer :))) thanks! oops i was viewing the pdf directly and not using typst-preview

Enivex commented 7 months ago

@Enter-tainer I had this happen again intermittently in 0.11.4. However, I can't consistently reproduce it