search

Enter-tainer / typst-preview

[DEPRECATED] Use tinymist instead
https://Enter-tainer.github.io/typst-preview/
MIT License
444 stars 21 forks source link

Add favicon when opening the preview in browser #239

Closed Parsifa1 closed 9 months ago

Parsifa1 commented 10 months ago

add an favicon for the localhost website for typst-preview.

Enter-tainer commented 10 months ago

The new icon LGTM. did you test it locally and see if it works or not?

Enter-tainer commented 9 months ago

The new icon LGTM. did you test it locally and see if it works or not?

image

it doesn't work unfortunately. This may require other changes in typst-preview

Myriad-Dreamin commented 9 months ago

The new icon LGTM. did you test it locally and see if it works or not?

image

it doesn't work unfortunately. This may require other changes in typst-preview

We perhaps must bundle it inside of the frontend like that:

<link rel="icon" type="image/svg+xml" href="data:image/svg+xml,LOVELY_SVG_FAVICON_HERE" />

This should ensure the frontend html to be a single file again.

Myriad-Dreamin commented 9 months ago

We may use https://cloudconvert.com/svg-to-ico for frontend icon. And https://cloudconvert.com/svg-to-png for extension icon. Constraints for rendering SVG images.

Parsifa1 commented 9 months ago

The new icon LGTM. did you test it locally and see if it works or not?

image

it doesn't work unfortunately. This may require other changes in typst-preview

sorry, i will try and do some test stuff

Parsifa1 commented 9 months ago

image

Done.