Closed aricka-lewis closed 1 year ago
@jeromeleecms and @stephanieboydcms can you please review this ticket.I will update the closing notes once the issue with zenhub comments is resolved. But below is the export in its entirety, showing the export filled out and in an empty state. Export View Filled In Export View Empty State Disclaimer
Thank you for a chance to review @akuas . I left minor alignment and such comments in Figma. Great job!
@stephanieboydcms Thanks, I'll look through them soon.
Full Export View: Filled Out Full Export View: Empty/Unanswered Fields
- The Executive Summary Section is unchanged.
- The Program Budget Tables changed to reflect table redesign.
- MMIS M&O not shown if there are no M&O activities
- Unchanged
- Will list all activities intro here
- Paragraph intro comes from activity snapshot
- Add Program Budget Source
- Add APD Type
- Add Update Type
- Add Medicaid Business Area
- Add branching style only when other is selected
- Add Total Medicaid Computable to section
- Add Medicaid Share to section
- Add Federal Share to section
- Add federal share 90% FFP, MMIS federal share 75%, MMIS Federal share 50% ffp and grand totals: federal mmis sub-headers to page
- Add MMIS M&O at 75% FFP table
- Change table design to reflect table redesign. 1st table header dark charcoal and 2nd table header gray
- Design largely unchanged just remove HIE/HIT
- Add federal state split field
- Add activity snapshot field and comprehensive activity overview section
- Separate from outcomes into separate section
- Activity Schedule will be where the activity 1: pharmacy management is
- Design unchanged
- Design is unchanged, besides the fact that we are no longer grouping key state personnel into this section
- Design unchanged
- Design unchanged
- Table changed to reflect new table redesign but there are two additional rows like it had been previously; activity total cost and total computable medicaid cost (fed + state share)
- FFY 2022-2023 total is unchanged
- Just the table styling has changed but contents are the same
Combined Activity Costs: Add match rate table headers to combined activity costs
Combined Activity Costs: Add key state personnel
Combined activity costs keep activity 1 total computable medicaid cost and total computable medicaid cost section
State and Contractor Cost Breakdown: Add key state personnel and APD point of contact signifier to the 1st key personnel
Make sure design reflects mmis update maintain total medicaid cost with federal and state share totals
State and Contractor Cost: Add % to represent medicaid share in table calculation
Summary Budget table: add match rate table headers
Summary Budget table: only show user selected match rates, so if there is no 50/50, there will be no table for it
Summary Budget Table: make sure it reflects mmis changes
- New page
- Add subsections followed by text based on user entry
- Design is the same, but most of the regulations have changed.
@akuas I had one minor alignment comment I left in Figma. Once that is fixed I am good for my review, pending @jeromeleecms , I am good to push. Great work Akua!
@stephanieboydcms Thanks for the review! Ditto of Stephanie's comment, I have made the changes that you both proposed, and I think this is ready for dev.
@akuas Just a couple final comments. Noted in the Figma, but:
1) The addition of the FFP match at the beginning of the activity description is fine, but it should show the FFYs since the FFP for each year is managed independently. 2) The Key Personnel in the Filled Out version of the design still shows that it's in Activity 1. It's correct in the closing notes and the empty state, but the filled out version should show KP in the separate table.
Everything else looks good. Can you also spin up a design ticket to capture the idea of converting the milestones into a table in the export/read only view?
@jeromeleecms For the 2nd point, I removed key state personnel from the activity 1. I think you are suggesting have a separate kp table there. We don't currently do that the for the budget and ffp and I don't think it is needed because the budget and ffp is at the activity level not apd level. So, if we add the kp table it would be shown by ffy not by activity. It makes sense to have the kp table in the proposed budget, but not here, in my opinion. What do you think?
@akuas You are correct, activity 1 shouldn't have any KP data in it all all. In the filled out version of the Figma, I'm still seeing them.
But yes, KP by FFY in the proposed budget is perfect.
@jeromeleecms I missed that one, but made the change. Now, I think it is ready for dev.
Thanks @akuas. @thetif This is ready for dev. This also includes the updated language that you made for "Medicaid Total Computable by FFY" in your other ticket.
created dev tickets
@SGilliamA1M This overlaps with #4488 and some of them are already being worked on. If this is good to close, we can close this design ticket.
Good to close.
We may have done this on this page in Figma: https://www.figma.com/file/6eVvo7JjvXiovGTR4BoVgK/CMS-eAPD-2022?node-id=0%3A16744
This task is done when...
[x] a list of changes to be made if this is improving an existing feature