Closed tbolt closed 1 year ago
Merging #4583 (6956342) into main (57ec9df) will increase coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #4583 +/- ##
==========================================
+ Coverage 94.30% 94.31% +0.01%
==========================================
Files 273 273
Lines 8660 8694 +34
Branches 1721 1746 +25
==========================================
+ Hits 8167 8200 +33
- Misses 469 470 +1
Partials 24 24
Flag | Coverage Δ | |
---|---|---|
api | ∅ <ø> (∅) |
|
common | 100.00% <ø> (ø) |
|
web | 94.05% <100.00%> (+0.01%) |
:arrow_up: |
Impacted Files | Coverage Δ | |
---|---|---|
e2e/cypress/page-objects/activity-schedule-page.js | 100.00% <ø> (ø) |
|
e2e/cypress/page-objects/export-page.js | 64.95% <ø> (ø) |
|
...vities/cost-allocation/CostAllocateFFPQuarterly.js | 100.00% <ø> (ø) |
|
...eb/src/pages/apd/activities/ffp/CostAllocateFFP.js | 97.61% <ø> (ø) |
|
...b/src/pages/apd/activities/ffp/FedStateSelector.js | 100.00% <ø> (ø) |
|
.../src/pages/apd/activities/ffp/MatchRateSelector.js | 100.00% <ø> (ø) |
|
...rc/pages/apd/executive-summary/ExecutiveSummary.js | 96.96% <ø> (ø) |
|
...src/pages/apd/proposed-budget/IncentivePayments.js | 94.91% <ø> (ø) |
|
...es/apd/proposed-budget/SummaryActivityBreakdown.js | 100.00% <ø> (ø) |
|
...es/apd/proposed-budget/SummaryKeyStatePersonnel.js | 100.00% <ø> (ø) |
|
... and 11 more |
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 57ec9df...6956342. Read the comment docs.
See this pull request in action: https://ec2-34-193-194-48.compute-1.amazonaws.com
6956342cadbb6fab1ad569c574969442b219e8a7
Looks good to me! Note: Executive summary couldn't be checked (page still crashes) so I checked them in Chromatic
Given | When | Then | Covered |
---|---|---|---|
a HITECH or MMIS APD | On the Proposed Budget page, Executive Summary page, Budget and FFP page, and the Activity Schedule Summary page | All changes to tables should only affect the Activity total cost table, Combined Activity Cost table, State and Contractor Cost breakdown table, Summary Budget Table, Budget and FFP table, Executive Summary Table, Schedule Summary by Activity, and Milestone Tables by Activity | ✅ |
a HITECH or MMIS APD | On the Proposed Budget page, Executive Summary page, Budget and FFP page, and the Activity Schedule Summary page | If a table has more than 4 rows, each row should alternate in color. Even numbered rows should be gray (#F1F1F1) | ✅ |
a HITECH or MMIS APD | Tables on the Proposed Budget page and Budget and FFP page | Subtotal rows should have a light yellow background color and Grand total rows should have a dark yellow background color | ✅ |
a HITECH or MMIS APD | Tables on the Executive Summary page | Total row should be light yellow. This is an exception to the totals/subtotals color scheme. (Verified w/ Akua) | ✅ |
a HITECH or MMIS APD | On the Proposed Budget page | Help text for the Summary Budget table section should be updated | ✅ |
a HITECH or MMIS APD | Tables on the Activity Schedule Summary; Combined Activity Costs and State and Contractor Cost Breakdown tables on the Proposed budget | The table header background color should change from black to gray to match the other tables | ✅ |
a HITECH or MMIS APD | Summary Budget Tables on the Proposed Budget | Federal total should come first before State total | ✅ |
a HITECH or MMIS APD | Milestone Tables by Activity on the Activity Schedule Summary page | Table header should be changed to the activity name. Subheaders should be Milestone List and Target completion date | ✅ |
Resolves #4506
Description
Updates to table designs
Chromatic approval
Significant changes or possible side effects
Automated test cases written
No new tests needed for these design changes. Tests were updated where needed.
Steps to manually verify this change
This pull request is ready to code review when
This pull request is ready to test when
This pull request is ready to review when the QA has
This pull request can be merged when