Closed thetif closed 1 year ago
Merging #4587 (ac54bc2) into main (adced20) will increase coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #4587 +/- ##
==========================================
+ Coverage 94.25% 94.26% +0.01%
==========================================
Files 264 264
Lines 8453 8472 +19
Branches 1808 1820 +12
==========================================
+ Hits 7967 7986 +19
Misses 464 464
Partials 22 22
Impacted Files | Coverage Δ | |
---|---|---|
e2e/cypress/helpers/apd/key-state-personnel.js | 100.00% <ø> (ø) |
|
web/src/pages/apd/ApdReadOnly.js | 100.00% <ø> (ø) |
|
...d/key-state-personnel/KeyStatePersonnelReadOnly.js | 95.83% <100.00%> (+3.24%) |
:arrow_up: |
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update adced20...ac54bc2. Read the comment docs.
See this pull request in action: https://ec2-50-17-66-188.compute-1.amazonaws.com
ac54bc26a15d6f8fd1af7614864cfb7325a6cf22
Looks good to me! Saved the storybook approving for design 😄 | Given | When | Then | Covered |
---|---|---|---|---|
a HITECH APD | On the export view | Key State Personnel section should be the same and not have any MMIS updates | ✅ | |
a MMIS APD | On the export view (use Chromatic if page crashes) | Key State Personnel section should match the data in the Key State Personnel page | ✅ | |
a MMIS APD | Key State Personnel data is changed (added KP/deleted KP/edited KP) | Key State Personnel section should match the changed data | 🟨 Cannot test since page still crashes | |
a MMIS APD | Key State Personnel data is blank | Key State Personnel section should match the empty state | ✅ |
Resolves #4554
Description
Updated the Key State Personnel read-only to match Figma updates. Added row for key personnel total medicaid costs for MMIS.
Automated test cases written
Steps to manually verify this change
You won't be able to view the MMIS APD, but you can verify it on storybook
This pull request is ready to code review when
This pull request is ready to test when
This pull request is ready to review when the QA has
This pull request can be merged when