Enterprise-CMCS / eAPD

CMS (Centers for Medicare and Medicaid Services) eAPD - Modernizing the APD experience
https://eapd.cms.gov
Other
58 stars 25 forks source link

updated key state personnel #4587

Closed thetif closed 1 year ago

thetif commented 1 year ago

Resolves #4554

Description

Updated the Key State Personnel read-only to match Figma updates. Added row for key personnel total medicaid costs for MMIS.

Automated test cases written

Given When Then Type (jest, tap, cypress)
a HITECH key person on the export view show FFY X Cost row jest
a MMIS key person on the export view show FFY Cost row and Total Computable Medicaid Cost row jest
a key person on the export view show the person's name, position, and email jest
a medicaid director on the export view show the director's name, email, and phone number jest
an empty medicaid director on the export view show "No Medicaid director was provided" jest
a medicaid office on the export view show the address jest
an empty medicaid office on the export view show "No Medicaid office was provided" jest
an empty medicaid director and medicaid office on the export view show "No Medicaid director and corresponding Medicaid office address was provided jest

Steps to manually verify this change

  1. open a HITECH APD
  2. go to Export and Submit page
  3. click Continue to Review
  4. scroll to Key State Personnel section

You won't be able to view the MMIS APD, but you can verify it on storybook

This pull request is ready to code review when

This pull request is ready to test when

This pull request is ready to review when the QA has

This pull request can be merged when

codecov[bot] commented 1 year ago

Codecov Report

Merging #4587 (ac54bc2) into main (adced20) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4587      +/-   ##
==========================================
+ Coverage   94.25%   94.26%   +0.01%     
==========================================
  Files         264      264              
  Lines        8453     8472      +19     
  Branches     1808     1820      +12     
==========================================
+ Hits         7967     7986      +19     
  Misses        464      464              
  Partials       22       22              
Impacted Files Coverage Δ
e2e/cypress/helpers/apd/key-state-personnel.js 100.00% <ø> (ø)
web/src/pages/apd/ApdReadOnly.js 100.00% <ø> (ø)
...d/key-state-personnel/KeyStatePersonnelReadOnly.js 95.83% <100.00%> (+3.24%) :arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update adced20...ac54bc2. Read the comment docs.

cms-eapd-bot commented 1 year ago

See this pull request in action: https://ec2-50-17-66-188.compute-1.amazonaws.com

ac54bc26a15d6f8fd1af7614864cfb7325a6cf22

mirano-darren commented 1 year ago
Looks good to me! Saved the storybook approving for design 😄 Given When Then Covered
a HITECH APD On the export view Key State Personnel section should be the same and not have any MMIS updates
a MMIS APD On the export view (use Chromatic if page crashes) Key State Personnel section should match the data in the Key State Personnel page
a MMIS APD Key State Personnel data is changed (added KP/deleted KP/edited KP) Key State Personnel section should match the changed data 🟨 Cannot test since page still crashes
a MMIS APD Key State Personnel data is blank Key State Personnel section should match the empty state