Closed thetif closed 1 year ago
Merging #4593 (8fc15fb) into main (2db1152) will decrease coverage by
0.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #4593 +/- ##
==========================================
- Coverage 94.27% 94.27% -0.01%
==========================================
Files 264 264
Lines 8454 8453 -1
Branches 1681 1681
==========================================
- Hits 7970 7969 -1
Misses 461 461
Partials 23 23
Flag | Coverage Δ | |
---|---|---|
api | ∅ <ø> (∅) |
|
common | 100.00% <ø> (ø) |
|
web | 94.00% <ø> (-0.01%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
...-and-compliance/AssurancesAndComplianceReadOnly.js | 100.00% <ø> (ø) |
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2db1152...8fc15fb. Read the comment docs.
See this pull request in action: https://ec2-34-192-163-36.compute-1.amazonaws.com
8fc15fb0ccfca7660d05117e908c061266f77886
Resolves #4539
Description
Updates the authentication for the endpoints. Removed the LaunchDarkly flag. Added a check for apikey. The rest of the auth is being handled through the WAF. Changed the patch endpoint to be a post, so that it was clearer.
This pull request is ready to code review when
Steps to manually verify this change
apikey
and set it to any value[{ "apdId": "apd id", "newStatus": "completed" }]
in the text area[{"apdId":"apd id","success":false,"error":"APD Id is invalid"}]
This pull request is ready to test when
This pull request is ready to review when the QA has
This pull request can be merged when