Enterprise-CMCS / eAPD

CMS (Centers for Medicare and Medicaid Services) eAPD - Modernizing the APD experience
https://eapd.cms.gov
Other
58 stars 25 forks source link

bbrooks/circleci-store-artifacts-20230317 #4617

Closed cthulhuplus closed 1 year ago

cthulhuplus commented 1 year ago

Resolves # Retrieving Stored Artifacts not working

Description

The retrieving of stored artifacts for staging seems to have broke. This remedies the issue by falling back to v1.1 of the CircleCI API, which worked in testing.

Chromatic Link

Significant changes or possible side effects

Automated test cases written

Given When Then Type (jest, tap, cypress)

Steps to manually verify this change

1. 2. 3.

This pull request is ready to code review when

This pull request is ready to test when

This pull request is ready to review when QA has

This pull request can be merged when

codecov[bot] commented 1 year ago

Codecov Report

Merging #4617 (4bde19b) into main (3a94636) will decrease coverage by 2.36%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4617      +/-   ##
==========================================
- Coverage   94.28%   91.92%   -2.36%     
==========================================
  Files         272      268       -4     
  Lines        8623     8450     -173     
  Branches     1713     1707       -6     
==========================================
- Hits         8130     7768     -362     
- Misses        469      649     +180     
- Partials       24       33       +9     
Flag Coverage Δ
api ∅ <ø> (?)
common 100.00% <ø> (ø)
web 91.55% <ø> (-2.47%) :arrow_down:

see 26 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3a94636...4bde19b. Read the comment docs.

cms-eapd-bot commented 1 year ago

See this pull request in action: https://ec2-3-213-107-82.compute-1.amazonaws.com