Enterprise-CMCS / eAPD

CMS (Centers for Medicare and Medicaid Services) eAPD - Modernizing the APD experience
https://eapd.cms.gov
Other
58 stars 25 forks source link

updated S3 set up #4631

Closed thetif closed 1 year ago

thetif commented 1 year ago

Resolves issue with opening docs and uploading images

Description

The S3 set up changed, this fixes the issues.

Steps to manually verify this change

  1. Verify that clicking How to Get Started opens the correct PDF
  2. Verify that clicking How to Access the eAPD opens the correct PDF
  3. Verify that clicking State Administrator Authorization Form opens the correct PDF
  4. Log in
  5. Open an APD
  6. Upload an image to a RichText field
  7. Verify that there is no error and the image is added
  8. Navigate back to the dashboard and then back to the APD
  9. Verify that the image is still displaying correctly

This pull request is ready to code review when

This pull request is ready to test when

This pull request is ready to review when QA has

This pull request can be merged when

codecov[bot] commented 1 year ago

Codecov Report

Merging #4631 (ba007ad) into main (df4dccd) will decrease coverage by 0.98%. The diff coverage is n/a.

:exclamation: Current head ba007ad differs from pull request most recent head 28d70eb. Consider uploading reports for the commit 28d70eb to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4631      +/-   ##
==========================================
- Coverage   94.32%   93.35%   -0.98%     
==========================================
  Files         273      272       -1     
  Lines        8694     8650      -44     
  Branches     1746     1741       -5     
==========================================
- Hits         8201     8075     -126     
- Misses        469      550      +81     
- Partials       24       25       +1     
Flag Coverage Δ
api ∅ <ø> (∅)
common 100.00% <ø> (ø)
web 93.04% <ø> (-1.03%) :arrow_down:

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update df4dccd...28d70eb. Read the comment docs.

cms-eapd-bot commented 1 year ago

See this pull request in action: https://ec2-34-232-189-82.compute-1.amazonaws.com

28d70eb2eb26f94b65caed5b4d3b18a7472fbd62