Closed mirano-darren closed 1 year ago
Merging #4640 (35c3f8e) into main (fd80377) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #4640 +/- ##
=======================================
Coverage 94.34% 94.35%
=======================================
Files 279 280 +1
Lines 8864 8873 +9
Branches 1787 1787
=======================================
+ Hits 8363 8372 +9
Misses 477 477
Partials 24 24
Flag | Coverage Δ | |
---|---|---|
api | ∅ <ø> (∅) |
|
common | 99.33% <ø> (ø) |
|
web | 94.08% <100.00%> (+<0.01%) |
:arrow_up: |
Impacted Files | Coverage Δ | |
---|---|---|
web/src/components/ApdUpdate.js | 97.22% <ø> (ø) |
|
web/src/components/MedicaidBusinessAreas.js | 100.00% <ø> (ø) |
|
.../src/pages/apd/activities/ffp/MatchRateSelector.js | 100.00% <ø> (ø) |
|
...pages/apd/activities/overview/FundingSourceForm.js | 95.00% <ø> (ø) |
|
...rc/pages/apd/apd-overview/ApdOverviewMMISFields.js | 100.00% <ø> (ø) |
|
...surances-and-compliance/AssurancesAndCompliance.js | 87.67% <ø> (ø) |
|
web/src/pages/apd/new/HitechUpdateStatus.js | 100.00% <ø> (ø) |
|
web/src/pages/apd/new/MmisUpdateStatus.js | 100.00% <ø> (ø) |
|
web/src/pages/login/SelectAffiliation.js | 97.29% <ø> (ø) |
|
web/src/components/ChoiceList.js | 100.00% <100.00%> (ø) |
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fd80377...35c3f8e. Read the comment docs.
This deploy was cleaned up.
Resolves #4551, #4405
Description
Resolves screen reader bug reading out each choice last. The problem was because of the aria components exclusive to the cms design system's ChoiceList component. The solution was to create our own ChoiceList wrapper, and removing these aria tags from the components. Also replaced everywhere we use the ChoiseList component, which resolves #4405 as well.
Chromatic Link
https://www.chromatic.com/build?appId=61d5b948cf6f17003a12bf77&number=1319
Significant changes or possible side effects
Automated test cases written
Steps to manually verify the bug fix (windows only)
Steps to manually verify the ChoiceList changes
This pull request is ready to code review when
This pull request is ready to test when
This pull request is ready to review when QA has
This pull request can be merged when