Enterprise-CMCS / eAPD

CMS (Centers for Medicare and Medicaid Services) eAPD - Modernizing the APD experience
https://eapd.cms.gov
Other
58 stars 25 forks source link

4613 [Feature] Create Read-only view for Conditions for Enhanced Funding #4642

Closed thetif closed 1 year ago

thetif commented 1 year ago

Resolves #4613

Description

Added the read-only view for Conditions for Enhanced Funding. Also added a module that lets you reuse arguments from a storybook story in your tests.

Chromatic Link

https://www.chromatic.com/pullrequest?appId=61d5b948cf6f17003a12bf77&number=4642

Significant changes or possible side effects

None

Automated test cases written

Given When Then Type (jest, tap, cypress)
a MMS APD on the Conditions and Enhanced Funding page conditions are empty display "No response was provided" for both values jest
a MMS APD on the Conditions and Enhanced Funding page qualification is no display "No, not applicable for enhanced funding, this activity has a 50/50 federal state split." for qualification and hide justification jest
a MMS APD on the Conditions and Enhanced Funding page qualification is yes and justification is empty display "Yes, this activity is qualified for enhanced funding." for qualification and "No response was provided" for justification jest
a MMS APD on the Conditions and Enhanced Funding page qualification is yes and justification has a value display "Yes, this activity is qualified for enhanced funding." for qualification and the justification jest

Steps to manually verify this change

This story can only be verified using the Chromatic link above

This pull request is ready to code review when

This pull request is ready to test when

This pull request is ready to review when QA has

This pull request can be merged when

codecov[bot] commented 1 year ago

Codecov Report

Merging #4642 (db34e3c) into main (d15b52a) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4642      +/-   ##
==========================================
+ Coverage   94.35%   94.36%   +0.01%     
==========================================
  Files         280      281       +1     
  Lines        8878     8895      +17     
  Branches     1788     1798      +10     
==========================================
+ Hits         8377     8394      +17     
  Misses        477      477              
  Partials       24       24              
Flag Coverage Δ
api ∅ <ø> (∅)
common 99.33% <ø> (ø)
web 94.10% <100.00%> (+0.01%) :arrow_up:
Impacted Files Coverage Δ
...ess/helpers/apd/activity/check-default-activity.js 100.00% <100.00%> (ø)
e2e/cypress/page-objects/export-page.js 64.95% <100.00%> (ø)
...ctivities/activities-dashboard/ActivityReadOnly.js 98.43% <100.00%> (+0.07%) :arrow_up:
...ed-funding/ConditionsForEnhancedFundingReadOnly.js 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d15b52a...db34e3c. Read the comment docs.

cms-eapd-bot commented 1 year ago

This deploy was cleaned up.