Enterprise-CMCS / eAPD

CMS (Centers for Medicare and Medicaid Services) eAPD - Modernizing the APD experience
https://eapd.cms.gov
Other
58 stars 25 forks source link

[Maintenance] fixing budget migration #4644

Closed thetif closed 1 year ago

thetif commented 1 year ago

Resolves budget migration issue

Description

I changed up the migration so that it does HITECH and MMIS separately because it seems to be having an issue setting the correct discriminator. I also changed the discriminators in the schemas to use constants.

This pull request is ready to code review when

This pull request is ready to test when

codecov[bot] commented 1 year ago

Codecov Report

Merging #4644 (c71bd99) into main (153d84a) will decrease coverage by 6.37%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4644      +/-   ##
==========================================
- Coverage   94.32%   87.95%   -6.37%     
==========================================
  Files         277      274       -3     
  Lines        8808     8603     -205     
  Branches     1773     1773              
==========================================
- Hits         8308     7567     -741     
- Misses        476      998     +522     
- Partials       24       38      +14     
Flag Coverage Δ
api ∅ <ø> (∅)
common 99.33% <100.00%> (+<0.01%) :arrow_up:
web 87.33% <ø> (-6.73%) :arrow_down:
Impacted Files Coverage Δ
common/utils/constants.js 100.00% <100.00%> (ø)

... and 25 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 153d84a...c71bd99. Read the comment docs.

cms-eapd-bot commented 1 year ago

This deploy was cleaned up.