Closed thetif closed 1 year ago
Merging #4646 (317f698) into main (6901dea) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #4646 +/- ##
=======================================
Coverage 94.32% 94.32%
=======================================
Files 277 277
Lines 8816 8816
Branches 1773 1773
=======================================
Hits 8316 8316
Misses 476 476
Partials 24 24
Flag | Coverage Δ | |
---|---|---|
api | ∅ <ø> (∅) |
|
common | 99.33% <ø> (ø) |
|
web | 94.06% <ø> (ø) |
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6901dea...317f698. Read the comment docs.
This deploy was cleaned up.
Resolves budget migration issues
Description
Tested on staging directly this time, so it is working. The issue was that the existing budgets didn't have a discriminator, so they couldn't be found by
HITECHBudget
orMMISBudget
to be updated. Also, when I tried just updating them usingBudget
without setting the__t
it wasn't adding the discriminator and losing the specific data. So in future migrations when you need to update an APD or Budget that hasn't been retrieved using their specific versions. You need to update them with the generic model and set the discriminator by hand.This pull request is ready to code review when
This pull request is ready to test when