Enterprise-CMCS / eAPD

CMS (Centers for Medicare and Medicaid Services) eAPD - Modernizing the APD experience
https://eapd.cms.gov
Other
58 stars 25 forks source link

4597 - [Feature] Display standard APD header on activities pages #4647

Closed Sun-Mountain closed 1 year ago

Sun-Mountain commented 1 year ago

Resolves #4597

Description

The APD header is not being shown on the activities pages, but it should be shown on those pages as well.

Chromatic Link

https://www.chromatic.com/build?appId=61d5b948cf6f17003a12bf77&number=1359

Automated test cases written

Given When Then Type (jest, tap, cypress)
Continue button test running in e2e will check for header on every page cypress

Steps to manually verify this change

  1. Open a new or existing apd
  2. Go to an activity page
  3. Ensure apd name header is present.

This pull request is ready to code review when

This pull request is ready to test when

This pull request is ready to review when QA has

This pull request can be merged when

codecov[bot] commented 1 year ago

Codecov Report

Merging #4647 (cb79118) into main (7484684) will decrease coverage by 6.32%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4647      +/-   ##
==========================================
- Coverage   94.35%   88.04%   -6.32%     
==========================================
  Files         280      277       -3     
  Lines        8877     8672     -205     
  Branches     1788     1788              
==========================================
- Hits         8376     7635     -741     
- Misses        477      999     +522     
- Partials       24       38      +14     
Flag Coverage Δ
api ∅ <ø> (∅)
common 99.33% <ø> (ø)
web 87.42% <100.00%> (-6.67%) :arrow_down:
Impacted Files Coverage Δ
common/utils/test-data/calculateBudget.js 100.00% <ø> (ø)
web/src/pages/apd/ApdPageRoutes.js 100.00% <ø> (ø)
e2e/cypress/helpers/apd/apd-navigation.js 100.00% <100.00%> (ø)
e2e/cypress/page-objects/activity-page.js 79.56% <100.00%> (ø)

... and 25 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7484684...cb79118. Read the comment docs.

cms-eapd-bot commented 1 year ago

This deploy was cleaned up.