Enterprise-CMCS / eAPD

CMS (Centers for Medicare and Medicaid Services) eAPD - Modernizing the APD experience
https://eapd.cms.gov
Other
58 stars 25 forks source link

4500 Add MDBT Budget Tables to Proposed Budget #4667

Closed tbolt closed 1 year ago

tbolt commented 1 year ago

Resolves #4500

Description

Updates to the Proposed Budget tables for MMIS

Chromatic Link

https://www.chromatic.com/pullrequest?appId=61d5b948cf6f17003a12bf77&number=4667

Significant changes or possible side effects

Updated budget to add in keyStatePersonnel for ddi and mando

Automated test cases written

Existing tests updated to account for new design / table / copy changes

Steps to manually verify this change

  1. Login to HITECH apd and verify existing Proposed Budget tables are the same (with one exception- the HIT/HIE/MMIS Total is now Subtotal)
  2. Login to MMIS type apd
  3. Verify all acceptance criteria is met and new designs are as specified according to the ticket and Figma

This pull request is ready to code review when

This pull request is ready to test when

This pull request is ready to review when QA has

This pull request can be merged when

codecov[bot] commented 1 year ago

Codecov Report

Merging #4667 (500ae70) into main (f184c7f) will increase coverage by 0.04%. The diff coverage is 99.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4667      +/-   ##
==========================================
+ Coverage   94.39%   94.43%   +0.04%     
==========================================
  Files         281      282       +1     
  Lines        8898     8989      +91     
  Branches     1797     1820      +23     
==========================================
+ Hits         8399     8489      +90     
- Misses        475      476       +1     
  Partials       24       24              
Flag Coverage Δ
api ∅ <ø> (∅)
common 99.16% <96.42%> (-0.18%) :arrow_down:
web 94.17% <100.00%> (+0.04%) :arrow_up:
Impacted Files Coverage Δ
common/utils/constants.js 100.00% <ø> (ø)
common/utils/test-data/calculateBudget.js 100.00% <ø> (ø)
common/utils/test-data/exampleMMISBudget.js 0.00% <0.00%> (ø)
...eb/src/pages/apd/proposed-budget/ProposedBudget.js 100.00% <ø> (ø)
common/utils/budget.js 99.24% <100.00%> (+0.05%) :arrow_up:
web/src/pages/apd/proposed-budget/BudgetSummary.js 100.00% <100.00%> (ø)
...pages/apd/proposed-budget/CombinedActivityCosts.js 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f184c7f...500ae70. Read the comment docs.

cms-eapd-bot commented 1 year ago

This deploy was cleaned up.

mirano-darren commented 1 year ago

Looks good to me! Well done these are some big table changes 😄 Tested on all tables:

Given When Then Covered
A MMIS APD with costs Changing the cost of an item The table is updated to reflect the change in cost
A MMIS APD with costs Changing the FFP split of an activity The tables are updated to reflect the change in split
A MMIS APD with costs Deleting an item The tables are updated to reflect the change in cost
A MMIS APD with costs Deleting a FFY The tables for that FFY should be deleted
stephanieboydcms commented 1 year ago

This looks good to me!