Closed Sun-Mountain closed 1 year ago
Merging #4668 (3c903ae) into main (deb46b7) will decrease coverage by
3.08%
. The diff coverage is94.08%
.
@@ Coverage Diff @@
## main #4668 +/- ##
==========================================
- Coverage 94.50% 91.43% -3.08%
==========================================
Files 282 283 +1
Lines 9012 9131 +119
Branches 1841 1864 +23
==========================================
- Hits 8517 8349 -168
- Misses 471 753 +282
- Partials 24 29 +5
Flag | Coverage Δ | |
---|---|---|
api | ∅ <ø> (∅) |
|
common | 99.16% <ø> (ø) |
|
web | 91.00% <94.08%> (-3.24%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
...evious-activities/MmisApdPreviousActivityTables.js | 75.47% <62.96%> (-17.39%) |
:arrow_down: |
...press/helpers/apd/date-dollar-inline-validation.js | 100.00% <100.00%> (ø) |
|
...e/cypress/page-objects/previous-activities-page.js | 100.00% <100.00%> (ø) |
|
...ies/cost-allocation/CostAllocation/OtherFunding.js | 94.59% <100.00%> (+1.11%) |
:arrow_up: |
...apd/activities/schedule-and-milestones/Schedule.js | 96.00% <100.00%> (-0.88%) |
:arrow_down: |
...ious-activities/HitechApdPreviousActivityTables.js | 100.00% <100.00%> (ø) |
|
...src/pages/apd/proposed-budget/IncentivePayments.js | 98.33% <100.00%> (+3.41%) |
:arrow_up: |
... and 11 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update deb46b7...3c903ae. Read the comment docs.
This deploy was cleaned up.
This looks good to go @Sun-Mountain
Resolves #4661
Description
Verifies inline validation is occurring on date and dollar fields, with the exception of the end date on activity schedule.
All dollar and date fields outside subforms should have inline validation.
The pages affected are:
Future Work The idea would be to have users indicated whether the activity schedule has an end date or not, and if it does then require an end date.
Chromatic Link
https://www.chromatic.com/build?appId=61d5b948cf6f17003a12bf77&number=1419
Automated test cases written
Steps to manually verify this change
(For the above pages)
This pull request is ready to code review when
This pull request is ready to test when
This pull request is ready to review when QA has
This pull request can be merged when