Enterprise-CMCS / eAPD

CMS (Centers for Medicare and Medicaid Services) eAPD - Modernizing the APD experience
https://eapd.cms.gov
Other
58 stars 25 forks source link

4575 State Priorities and Scope admin check issue #4670

Closed tbolt closed 1 year ago

tbolt commented 1 year ago

Resolves #4575

Description

Resolves bug where the validation was triggering in State Priorities fields even when the admin check was not enabled

Steps to manually verify this change

  1. Login to MMIS apd
  2. Verify that the inline validation does not trigger when the admin check is turned off

This pull request is ready to code review when

This pull request is ready to test when

This pull request is ready to review when QA has

This pull request can be merged when

codecov[bot] commented 1 year ago

Codecov Report

Merging #4670 (d8ed859) into main (27e2842) will decrease coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4670      +/-   ##
==========================================
- Coverage   94.43%   94.41%   -0.02%     
==========================================
  Files         282      281       -1     
  Lines        8989     8959      -30     
  Branches     1820     1822       +2     
==========================================
- Hits         8489     8459      -30     
  Misses        476      476              
  Partials       24       24              
Flag Coverage Δ
api ∅ <ø> (∅)
common 99.16% <ø> (ø)
web 94.15% <100.00%> (-0.03%) :arrow_down:
Impacted Files Coverage Δ
...te-priorities-and-scope/StatePrioritiesAndScope.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 27e2842...d8ed859. Read the comment docs.

cms-eapd-bot commented 1 year ago

This deploy was cleaned up.