Enterprise-CMCS / eAPD

CMS (Centers for Medicare and Medicaid Services) eAPD - Modernizing the APD experience
https://eapd.cms.gov
Other
58 stars 25 forks source link

4586 Fix Activities Dashboard alert not going away when new activities are added #4671

Closed tbolt closed 1 year ago

tbolt commented 1 year ago

Resolves #4586

Description

Fixes an issue on the activities dashboard page where if you add an a new activity, the alert banner does not disappear.

Steps to manually verify this change

  1. Login to an MMIS APD that doesn't have any existing activities (or delete all current ones)
  2. Verify that the alert about no activities is displayed
  3. Add an activity and verify the alert goes away

This pull request is ready to code review when

This pull request is ready to test when

This pull request is ready to review when QA has

This pull request can be merged when

codecov[bot] commented 1 year ago

Codecov Report

Merging #4671 (dd5fed0) into main (96dd719) will decrease coverage by 6.14%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4671      +/-   ##
==========================================
- Coverage   94.43%   88.29%   -6.14%     
==========================================
  Files         282      279       -3     
  Lines        8992     8786     -206     
  Branches     1823     1823              
==========================================
- Hits         8492     7758     -734     
- Misses        476      991     +515     
- Partials       24       37      +13     
Flag Coverage Δ
api ∅ <ø> (∅)
common 99.16% <ø> (ø)
web 87.67% <ø> (-6.50%) :arrow_down:
Impacted Files Coverage Δ
...vities/activities-dashboard/ActivitiesDashboard.js 100.00% <ø> (ø)

... and 24 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 96dd719...dd5fed0. Read the comment docs.

cms-eapd-bot commented 1 year ago

This deploy was cleaned up.