Enterprise-CMCS / eAPD

CMS (Centers for Medicare and Medicaid Services) eAPD - Modernizing the APD experience
https://eapd.cms.gov
Other
58 stars 25 forks source link

[Bug] Key State Personnel being added to Executive Summary - Activities Totals #4672

Closed tbolt closed 1 year ago

tbolt commented 1 year ago

Description

As noted in this comment on the 4474 PR the key state personnel totals are being added to the activities section in executive summary for MMIS APDs. Key State Personnel in MMIS are not supposed to be a part of the activities totals.

Steps to reproduce

  1. Create new MMIS APD
  2. Add a key state personnel
  3. View Executive Summary and note that the budget is adding the key state personnel to activities section (see screenshot below)

Expected results- In MMIS APDs Key State Personnel are not added to the activities totals

Actual results-

Role Affected

Environment

Browser

Logs or error output/Screenshot/Video- (at least 1 of these) Screenshot 2023-04-13 at 1.48.30 PM.png

amyd11 commented 1 year ago

The changes to resolve this bug involve some UI tweaking such as modifying the section titles. This makes it clearer that these totals are not just the totals of the activities, but the overall total cost. The total cost should include both activities and key state personnel.

If we want to include the total cost of activities without key state personnel as part of the Executive Summary then it’s recommended to do that in another ticket since we want these values to be part of the budget data. The ticket should include updates to the budget model to add the necessary fields for these calculated values and updates to the calculateBudget function for the computations of those values.