Enterprise-CMCS / eAPD

CMS (Centers for Medicare and Medicaid Services) eAPD - Modernizing the APD experience
https://eapd.cms.gov
Other
58 stars 25 forks source link

4556 Updates to export/read-only proposed budget section #4674

Closed tbolt closed 1 year ago

tbolt commented 1 year ago

Resolves #4556

Description

Updates the export/read-only view to not show the help text and alert for the proposed budget section

Chromatic Link

https://www.chromatic.com/pullrequest?appId=61d5b948cf6f17003a12bf77&number=4674

Significant changes or possible side effects

None

Automated test cases written

Given When Then Type (jest, tap, cypress)
an MMIS apd viewing the read-only export page proposed budget section should render properly enzyme snapshot

Steps to manually verify this change

  1. Login and view a MMIS apd
  2. Navigate to the read-only/export view
  3. Verify the help text and alert box is no longer displayed in the proposed budget section

This pull request is ready to code review when

This pull request is ready to test when

This pull request is ready to review when QA has

This pull request can be merged when

codecov[bot] commented 1 year ago

Codecov Report

Merging #4674 (636d2ef) into main (76bf1a3) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4674   +/-   ##
=======================================
  Coverage   91.73%   91.73%           
=======================================
  Files         285      285           
  Lines        9203     9210    +7     
  Branches     1888     1894    +6     
=======================================
+ Hits         8442     8449    +7     
  Misses        732      732           
  Partials       29       29           
Flag Coverage Δ
api ∅ <ø> (∅)
common 98.75% <ø> (ø)
web 91.35% <100.00%> (+<0.01%) :arrow_up:
Impacted Files Coverage Δ
...ages/apd/proposed-budget/ProposedBudgetReadOnly.js 100.00% <ø> (ø)
.../apd/security-planning/SecurityPlanningReadOnly.js 100.00% <ø> (ø)
web/src/pages/apd/proposed-budget/BudgetSummary.js 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 76bf1a3...636d2ef. Read the comment docs.

cms-eapd-bot commented 1 year ago

This deploy was cleaned up.