Enterprise-CMCS / eAPD

CMS (Centers for Medicare and Medicaid Services) eAPD - Modernizing the APD experience
https://eapd.cms.gov
Other
58 stars 25 forks source link

4558 [Feature] Update Read-Only View for MMIS changes to Executive Summary #4678

Closed amyd11 closed 1 year ago

amyd11 commented 1 year ago

Resolves #4558

Description

Updates to the Export view's Executive Summary section for MMIS APDs.

Chromatic Link

https://www.chromatic.com/build?appId=61d5b948cf6f17003a12bf77&number=1456

Significant changes or possible side effects

Automated test cases written

Given When Then Type (jest, tap, cypress)
MMIS APD Export View Program Budget Tables section no budget data is present for DDI DDI table is NOT visible jest
MMIS APD Export View Program Budget Tables section no budget data is present for M&O M&O table is NOT visible jest
MMIS APD Export View Program Budget Tables section no tables are visible No tables message displays jest
selectBudgetExecutiveSummary selector activity summary data available data selected contains activity summary as summary jest
selectBudgetExecutiveSummary selector no activity summary data available; activity snapshot data available data selected contains activity snapshot as summary jest

Steps to manually verify this change

  1. For MMIS APD without any budget data, go to Export & Submit > Continue to Review and verify that the Program Budget Tables section displays the No Table message (neither the DDI table nor M&O table are present)
  2. For MMIS APD with budget data, go to Export & Submit > Continue to Review and verify that the Program Budget Tables section displays the DDI and/or M&O tables depending on what budget data exists for the chosen APD.
  3. For any MMIS APD, go to Export & Submit > Continue to Review and verify that below each Activity name, the same text inside the APD Overview snapshot displays.

This pull request is ready to code review when

This pull request is ready to test when

This pull request is ready to review when QA has

This pull request can be merged when

codecov[bot] commented 1 year ago

Codecov Report

Merging #4678 (83d3c76) into main (00bf1d2) will decrease coverage by 0.02%. The diff coverage is 95.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4678      +/-   ##
==========================================
- Coverage   91.73%   91.72%   -0.02%     
==========================================
  Files         285      285              
  Lines        9210     9207       -3     
  Branches     1894     1884      -10     
==========================================
- Hits         8449     8445       -4     
- Misses        732      733       +1     
  Partials       29       29              
Flag Coverage Δ
api ∅ <ø> (∅)
common 98.75% <ø> (ø)
web 91.33% <95.00%> (-0.02%) :arrow_down:
Impacted Files Coverage Δ
.../apd/executive-summary/ExecutiveSummaryReadOnly.js 100.00% <ø> (ø)
...pages/apd/executive-summary/HitechBudgetSummary.js 100.00% <ø> (ø)
...ious-activities/HitechApdPreviousActivityTables.js 100.00% <ø> (ø)
...evious-activities/MmisApdPreviousActivityTables.js 75.47% <ø> (ø)
web/src/redux/selectors/budget.selectors.js 94.73% <50.00%> (+0.29%) :arrow_up:
...es/apd/executive-summary/ExecutiveSummaryBudget.js 85.71% <100.00%> (ø)
...c/pages/apd/executive-summary/MmisBudgetSummary.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 00bf1d2...83d3c76. Read the comment docs.

cms-eapd-bot commented 1 year ago

This deploy was cleaned up.