Enterprise-CMCS / eAPD

CMS (Centers for Medicare and Medicaid Services) eAPD - Modernizing the APD experience
https://eapd.cms.gov
Other
58 stars 25 forks source link

Remove Launchdarkly #4681

Closed thetif closed 1 year ago

thetif commented 1 year ago

Resolves the need for LaunchDarkly

Description

Removes LaunchDarkly from the application. Turns all previously flagged code "on". Fully enables MMIS and adminCheck. Created a work around for the new code that shows or hides New Apdland. Created work around for sysadmin and just hardcoded access for the username 'sysadmin'.

Chromatic Link

https://www.chromatic.com/pullrequest?appId=61d5b948cf6f17003a12bf77&number=4681

Significant changes or possible side effects

Enabled all beta feature code.

Steps to manually verify this change

  1. Login as betauser and see that New Apdland is not available
  2. Login as norole and see that New Apdland is available
  3. Login as sysadmin and see that you have access to all states, click on one state
  4. Verify that the Create new APD button isn't visible
  5. Login as state admin, verify that you can create an MMIS APD and that it looks right

This pull request is ready to code review when

This pull request is ready to test when

This pull request is ready to review when QA has

This pull request can be merged when

codecov[bot] commented 1 year ago

Codecov Report

Merging #4681 (0a55127) into main (5639977) will decrease coverage by 1.14%. The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4681      +/-   ##
==========================================
- Coverage   91.78%   90.65%   -1.14%     
==========================================
  Files         288      288              
  Lines        9300     9252      -48     
  Branches     1891     1878      -13     
==========================================
- Hits         8536     8387     -149     
- Misses        735      826      +91     
- Partials       29       39      +10     
Flag Coverage Δ
api ∅ <ø> (∅)
common 99.17% <100.00%> (+0.42%) :arrow_up:
web 90.17% <76.92%> (-1.23%) :arrow_down:
Impacted Files Coverage Δ
e2e/cypress/helpers/apd/apd-overview.js 82.45% <ø> (-0.31%) :arrow_down:
...e/cypress/helpers/apd/assurances-and-compliance.js 60.58% <ø> (-0.41%) :arrow_down:
...press/helpers/apd/date-dollar-inline-validation.js 100.00% <ø> (ø)
e2e/cypress/helpers/apd/proposed-budget.js 61.76% <ø> (+0.33%) :arrow_up:
e2e/cypress/support/commands.js 67.45% <ø> (-5.94%) :arrow_down:
web/src/containers/ApdApplication.js 96.96% <ø> (-3.04%) :arrow_down:
web/src/containers/App.js 100.00% <ø> (ø)
web/src/containers/Root.js 100.00% <ø> (ø)
web/src/pages/apd/export/ApdExport.js 100.00% <ø> (+6.66%) :arrow_up:
web/src/util/hooks.js 0.00% <0.00%> (-100.00%) :arrow_down:
... and 6 more

... and 18 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5639977...0a55127. Read the comment docs.

cms-eapd-bot commented 1 year ago

This deploy was cleaned up.