Enterprise-CMCS / eAPD

CMS (Centers for Medicare and Medicaid Services) eAPD - Modernizing the APD experience
https://eapd.cms.gov
Other
58 stars 25 forks source link

4662 [Maintenance] Add periods to all the inline validation error messages #4682

Closed Sun-Mountain closed 1 year ago

Sun-Mountain commented 1 year ago

Resolves #4662

Description

For consistency, add punctuation to the end of every error message.

Chromatic Link

https://www.chromatic.com/build?appId=61d5b948cf6f17003a12bf77&number=1484

This pull request is ready to code review when

This pull request is ready to test when

This pull request is ready to review when QA has

This pull request can be merged when

codecov[bot] commented 1 year ago

Codecov Report

Merging #4682 (19a7c25) into main (261651b) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4682   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files         286      286           
  Lines        9290     9290           
  Branches     1894     1894           
=======================================
  Hits         8525     8525           
  Misses        736      736           
  Partials       29       29           
Flag Coverage Δ
api ∅ <ø> (∅)
common 98.75% <ø> (ø)
web 91.38% <100.00%> (ø)
Impacted Files Coverage Δ
e2e/cypress/helpers/mmis/mmis-admin-check.js 100.00% <ø> (ø)
...vities/cost-allocation/CostAllocateFFPQuarterly.js 100.00% <ø> (ø)
...e/cypress/helpers/apd/assurances-and-compliance.js 60.99% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 261651b...19a7c25. Read the comment docs.

cms-eapd-bot commented 1 year ago

This deploy was cleaned up.