Enterprise-CMCS / eAPD

CMS (Centers for Medicare and Medicaid Services) eAPD - Modernizing the APD experience
https://eapd.cms.gov
Other
58 stars 25 forks source link

Dmirano/4532 cypress valid mmis apd #4684

Closed mirano-darren closed 1 year ago

mirano-darren commented 1 year ago

Resolves #4532

Description

creates a valid mmis apd from scratch

Chromatic Link

Significant changes or possible side effects

Automated test cases written

Given When Then Type (jest, tap, cypress)

Steps to manually verify this change

1. 2. 3.

This pull request is ready to code review when

This pull request is ready to test when

This pull request is ready to review when QA has

This pull request can be merged when

codecov[bot] commented 1 year ago

Codecov Report

Merging #4684 (05a8a79) into main (27e40b1) will decrease coverage by 0.28%. The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4684      +/-   ##
==========================================
- Coverage   91.56%   91.29%   -0.28%     
==========================================
  Files         288      289       +1     
  Lines        9252     9525     +273     
  Branches     1878     1916      +38     
==========================================
+ Hits         8472     8696     +224     
- Misses        751      797      +46     
- Partials       29       32       +3     
Flag Coverage Δ
api ∅ <ø> (∅)
common 99.17% <ø> (ø)
web 90.87% <91.66%> (-0.28%) :arrow_down:
Impacted Files Coverage Δ
...ress/helpers/apd/results-of-previous-activities.js 59.37% <70.58%> (+6.25%) :arrow_up:
e2e/cypress/helpers/apd/key-state-personnel.js 77.85% <74.19%> (-2.61%) :arrow_down:
e2e/cypress/helpers/apd/apd-overview.js 80.34% <88.46%> (-2.12%) :arrow_down:
.../cypress/helpers/apd/activity/add-MMIS-activity.js 100.00% <100.00%> (ø)
.../cypress/helpers/apd/state-priorities-and-scope.js 100.00% <100.00%> (ø)
e2e/cypress/helpers/mmis/mmis-security-planning.js 100.00% <100.00%> (ø)
...e/cypress/page-objects/previous-activities-page.js 100.00% <100.00%> (ø)
e2e/cypress/support/commands.js 72.54% <100.00%> (ø)
...evious-activities/MmisApdPreviousActivityTables.js 96.00% <100.00%> (+20.52%) :arrow_up:

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 27e40b1...05a8a79. Read the comment docs.

cms-eapd-bot commented 1 year ago

This deploy was cleaned up.