4672 [Bug] Key State Personnel being added to Executive Summary - Activities Totals

[amyd11]

Resolves #4672

Description

Problem: The activities totals displaying in the Activity Summary of the Executive Summary pages are not reflective of the sum costs of activities (because the amounts include key state personnel costs).

Solution: The changes to resolve this bug involve some UI tweaking such as modifying the section titles. This makes it clearer that these totals are not just the totals of the activities, but the overall total cost. The total cost should include both activities and key state personnel.

Future Option: If we want to include the total cost of activities without key state personnel as part of the Executive Summary then it’s recommended to do that in another ticket since we want these values to be part of the budget data. The ticket should include updates to the budget model to add the necessary fields for these calculated values and updates to the calculateBudget function for the computations of those values.

Chromatic Link

Significant changes or possible side effects

• Modifying Total Activities Cost sections to be called Total Cost and restyling headings
• Included empty state for Activities section in Executive Summary (on edit and read only pages)
• Using ActivityExecutiveSummary component where possible
• Converted ffyList function to a component
• Miscellaneous cleanup

Automated test cases written

Given	When	Then	Type (jest, tap, cypress)

Steps to manually verify this change

1. 2. 3.

This pull request is ready to code review when

• [ ] Automated tests are updated (and all tests are passing)
• [ ] New automated test cases are documented above
• [ ] Chromatic link added above
• [ ] Pull request has been labeled, if applicable with feature, content, bug, tests, refactor
• [ ] Associated OpenAPI documentation has been updated
• [ ] The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented

This pull request is ready to test when

• [ ] Code has been reviewed by someone other than the original author

This pull request is ready to review when QA has

• [ ] Verified the functionality related to the change
• [ ] Verified that the change works with Narrator on Windows
• [ ] Verified that the change works with VoiceOver on Mac
• [ ] Verified all updated pages with the WAVE tool
• [ ] Verified tab and keyboard navigation functionality

This pull request can be merged when

• [ ] Design has approved the experience
• [ ] Product has approved the experience

[codecov[bot]]

Codecov Report

Merging #4685 (b3d6d58) into main (ea23fc8) will decrease coverage by 0.01%. The diff coverage is 94.87%.

@@            Coverage Diff             @@
##             main    #4685      +/-   ##
==========================================
- Coverage   91.78%   91.78%   -0.01%     
==========================================
  Files         287      288       +1     
  Lines        9302     9300       -2     
  Branches     1895     1891       -4     
==========================================
- Hits         8538     8536       -2     
  Misses        735      735              
  Partials       29       29              

Flag	Coverage Δ
api	∅ <ø> (∅)
common	98.75% <ø> (ø)
web	91.40% <94.87%> (-0.01%)	:arrow_down:

Impacted Files	Coverage Δ
e2e/cypress/page-objects/executive-summary-page.js	56.09% <ø> (ø)
.../apd/executive-summary/ExecutiveSummaryReadOnly.js	100.00% <ø> (ø)
web/src/util/apd.js	100.00% <ø> (ø)
...rc/pages/apd/executive-summary/ExecutiveSummary.js	96.15% <85.71%> (-0.82%)	:arrow_down:
...es/apd/executive-summary/ExecutiveSummaryBudget.js	86.36% <92.30%> (+0.64%)	:arrow_up:
e2e/cypress/page-objects/export-page.js	57.47% <100.00%> (ø)
web/src/components/FFYList.js	100.00% <100.00%> (ø)
.../apd/executive-summary/ActivityExecutiveSummary.js	100.00% <100.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea23fc8...b3d6d58. Read the comment docs.

[cms-eapd-bot]

This deploy was cleaned up.