Enterprise-CMCS / eAPD

CMS (Centers for Medicare and Medicaid Services) eAPD - Modernizing the APD experience
https://eapd.cms.gov
Other
58 stars 25 forks source link

Admin Check Stop Button #4686

Closed Sun-Mountain closed 1 year ago

Sun-Mountain commented 1 year ago

Resolves # No Existing Issue

Description

For accessibility and UX issues, I updated the button from this:

Screenshot 2023-04-20 at 11 10 33 AM

to this:

Screenshot 2023-04-20 at 11 06 39 AM

This makes the button to end admin check more easily recognizable.

Chromatic Link

https://www.chromatic.com/build?appId=61d5b948cf6f17003a12bf77&number=1499

Automated test cases written

N/A

Steps to manually verify this change

  1. Open admin check on an APD
  2. Verify button looks as pictured

This pull request is ready to code review when

This pull request is ready to test when

This pull request is ready to review when QA has

This pull request can be merged when

codecov[bot] commented 1 year ago

Codecov Report

Merging #4686 (8879468) into main (1fb53dd) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4686   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files         287      287           
  Lines        9301     9302    +1     
  Branches     1895     1895           
=======================================
+ Hits         8537     8538    +1     
  Misses        735      735           
  Partials       29       29           
Flag Coverage Δ
api ∅ <ø> (∅)
common 98.75% <ø> (ø)
web 91.40% <100.00%> (+<0.01%) :arrow_up:
Impacted Files Coverage Δ
web/src/components/AdminCheckPanel.js 95.12% <ø> (ø)
web/src/components/Icons.js 94.11% <100.00%> (+0.36%) :arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1fb53dd...8879468. Read the comment docs.

cms-eapd-bot commented 1 year ago

This deploy was cleaned up.