EnterpriseDB / barman

Barman - Backup and Recovery Manager for PostgreSQL
https://www.pgbarman.org/
GNU General Public License v3.0
2.07k stars 191 forks source link

barman recover write recovery.conf with barman-wal-restore -j when -j is warranted. #188

Open dvlhntr opened 5 years ago

dvlhntr commented 5 years ago

barman recover won't build recovery.conf with -j when appropriate (or custom if warranted?)

seems like it should write the custom decompression.

barman-wal-restore -j server.conf looks like:

.... compression = custom custom_compression_filter = pbzip2 custom_decompression_filter = bunzip2 ...

barman recover did not write a recovery.conf with barman-wal-restore -j or somehow wedge in a custom bunzip2.

seems kind of like it should, but this might be due to the 'custom compression/decompression' stuff.

martinmarques commented 2 months ago

I think there's some confusion with the GUCs and the options used with barman-wal-restore. The -j and -z options from barman-wal-restore are for compressing before transfer, to reduce network usage. The custom compression option in Barman is for compressing the WALs at archive time, that is, when barman archive-wal is executed directly or indirectly, it will apply the compression algorithm to the WAL, if appropriate. We feel that this is an enhancement. I'm opening an internal ticket to track this. We'll share feedback later