search

EnterpriseDB / barman

Barman - Backup and Recovery Manager for PostgreSQL
https://www.pgbarman.org/
GNU General Public License v3.0
2.07k stars 191 forks source link

Change postgres executor for incremental backups #932

Closed gustabowill closed 3 months ago

gustabowill commented 3 months ago

Changes the postgres executor and related classes to handle the new --incremental CLI argument. This first part is mostly only concerned about passing the argument correctly to the pg_basebackup command. I also added a method to get the manifest of the parent backup, although I'm not so sure if it was the best way to do it.

barthisrael commented 3 months ago

The PR looks good.

I'm only missing a unit test for the PgBaseBackup class -- check if incremental is passed down when there is a parent manifest.

For the executor itself I think we can leave it as it is right now as we might refactor this a bit through BAR-165.