search

EnterpriseDB / barman

Barman - Backup and Recovery Manager for PostgreSQL
https://www.pgbarman.org/
GNU General Public License v3.0
2.07k stars 191 forks source link

Verify that the Postgres version is 17 or newer on incremental backups #942

Closed bleidens closed 3 months ago

bleidens commented 3 months ago

Performing an incremental backup using Postgres mode requires the Postgres server's version to be 17 or newer. This PR builds from the validation methods introduced by BAR-160 (validate_backup_args and _validate_incremental_backup_configs), adding a check for the Postgres server's version and issue an error if it's not compatible with incremental backups (<17).

References: BAR-163

gcalacoci commented 3 months ago

Looks good. Let's squash the commits (code and black reformat)

I do agree. Rebase, squash and merge @bleidens

barthisrael commented 3 months ago

@bleidens I can see you force pushed a few minutes ago, likely to add some changes from master. We need to squash your commit with the "black reformat" commit. Besides that, we need to update your tests/test_backup.py again, as I just merged another PR, which created a conflict here.

bleidens commented 3 months ago

@barthisrael Yes, I just finished resolving the conflicts with the previous merge, I will now take a look at the new conflicts in tests/test_backup.py and squash everything after it's done, thanks for the update