search

EnterpriseDB / barman

Barman - Backup and Recovery Manager for PostgreSQL
https://www.pgbarman.org/
GNU General Public License v3.0
2.14k stars 193 forks source link

uses shutil.move instead of copy and unlink #960

Closed toydarian closed 4 months ago

toydarian commented 4 months ago

This should speed up serving wal-files from the spool-directory, in case pg_wal and the spool-directory are on the same filesystem, as in this case the file is renamed instead of copied.
If those directories are on different file-systems, this doesn't change anything, as shutil.move will do the same 2-step-process (copy and remove) in that case. Docs for reference.

Also see ticket #943

martinmarques commented 4 months ago

The only thing I'd like to see added is a note to the docs regarding the performance, but conversations are happening inside the team to redesign the whole docs, so I'm going to add an internal ticket for us to track this little piece of doc changes to the architecture part.