search

EnterpriseDB / edb-installers

PostgreSQL installers packaged by EDB
34 stars 8 forks source link

[DB-1331] Adding support to build server with LZ4 support #23

Closed Semab-Tariq closed 3 years ago

Semab-Tariq commented 3 years ago

Hi @sandeep-edb can you please review/merge this request?

Semab-Tariq commented 3 years ago

Hi @sandeep-edb

1) When I saw this files_to_project_map.txt file I only found .dll and .exe files I don't see any .so or .dylib file so I thought it is only for Windows.

I spoke with Basha about adding macOS libraries names inside files_to_project_map.txt he says

i think there is no separate file for mac so try to add there for mac and build and check with Sandeep after that.

So I added macOS libraries names there and then generated both macOS and Windows64 installers against and checked License files and LZ4 support everything is working as expected.

2) I guess LZ4 support is working fine by only copying liblz4.dll inside bin so I didn't think of copying liblz4.lib in lib But if you still think we should add .lib as well I can do that.

Semab-Tariq commented 3 years ago

Hi @sandeep-edb please review the latest commit