search

EnterpriseDB / mongo_fdw

PostgreSQL foreign data wrapper for MongoDB
GNU Lesser General Public License v3.0
326 stars 70 forks source link

Add PostgreSQL version 10 to all Makefiles #92

Closed andreasscherbaum closed 6 years ago

andreasscherbaum commented 6 years ago

This PR adds PostgreSQL version 10 to the version check in all Makefiles.

Should fix #88

SmilingNavern commented 6 years ago

@andreasscherbaum actually it should be 10.0, not 10. If i understand correctly(right now i am trying to build this extension for our postgres 10)

andreasscherbaum commented 6 years ago

You might be correct here.

Let me test this when I'm back home (beginning next week).

andreasscherbaum commented 6 years ago

Changed the code from "10" to "10.0", seems to work.

andreasscherbaum commented 6 years ago

Ping @ibrarahmad, can you see if this can be merged? Would like to remove the workaround from our code.

Thanks, Andreas

ahsanhadi commented 6 years ago

On Fri, Dec 29, 2017 at 3:34 PM, Andreas Scherbaum <notifications@github.com

wrote:

Ping @ibrarahmad https://github.com/ibrarahmad, can you see if this can be merged? Would like to remove the workaround from our code.

Yes Ibrar can merge this next week when he is back from vacations...

Thanks, Andreas

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/EnterpriseDB/mongo_fdw/pull/92#issuecomment-354428811, or mute the thread https://github.com/notifications/unsubscribe-auth/AHmqpLYbj5znsNzE867KUZD9ycAUL8Ucks5tFMAugaJpZM4QyapI .

-- Ahsan Hadi Snr Director Product Development EnterpriseDB Corporation The Enterprise Postgres Company

Phone: +92-51-8358874 Mobile: +92-333-5162114

Website: www.enterprisedb.com EnterpriseDB Blog: http://blogs.enterprisedb.com/ Follow us on Twitter: http://www.twitter.com/enterprisedb

This e-mail message (and any attachment) is intended for the use of the individual or entity to whom it is addressed. This message contains information from EnterpriseDB Corporation that may be privileged, confidential, or exempt from disclosure under applicable law. If you are not the intended recipient or authorized to receive this for the intended recipient, any use, dissemination, distribution, retention, archiving, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender immediately by reply e-mail and delete this message.

andreasscherbaum commented 6 years ago

Ah, perfect, thanks. Next week is fine, I just stumbled over it because the todo popped up on my side.