search

EnterpriseDB / mysql_fdw

PostgreSQL foreign data wrapper for MySQL
Other
523 stars 161 forks source link

PostgreSQL 12 support #186

Closed devrimgunduz closed 2 years ago

devrimgunduz commented 4 years ago

Hi,

mysql_fdw fails to compile against PostgreSQL 12. Can you please fix it? v12 is due next week.

Thanks!

gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -g -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fPIC -I/usr/include/mysql -I/usr/include/mysql/mysql -D _MYSQL_LIBNAME=\"libmysqlclient.so\" -I. -I./ -I/usr/pgsql-12/include/server -I/usr/pgsql-12/include/internal -D_GNU_SOURCE -I/usr/include/libxml2 -I/usr/include -c -o connection.o connection.c In file included from connection.c:17: mysql_fdw.h:31:10: fatal error: nodes/relation.h: No such file or directory 31 | #include "nodes/relation.h" | ^~~~~~~~~~~~~~~~~~ compilation terminated.

df7cb commented 4 years ago

Version 2.5.2 supports version 12 now, but breaks support for everything older:

/home/cbe/projects/postgresql/mysql-fdw/postgresql-mysql-fdw/option.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -g -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -fno-omit-frame-pointer -g -O2 -fdebug-prefix-map=/home/cbe/projects/postgresql/mysql-fdw/postgresql-mysql-fdw=. -fstack-protector-strong -Wformat -Werror=format-security -fPIC -I/usr/include/mariadb -I/usr/include/mariadb/mysql -D _MYSQL_LIBNAME=\"libmysqlclient.so\" -I. -I/home/cbe/projects/postgresql/mysql-fdw/postgresql-mysql-fdw -I/usr/include/postgresql/11/server -I/usr/include/postgresql/internal  -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include/mit-krb5  -c -o deparse.o /home/cbe/projects/postgresql/mysql-fdw/postgresql-mysql-fdw/deparse.c
/home/cbe/projects/postgresql/mysql-fdw/postgresql-mysql-fdw/deparse.c:94:37: error: unknown type name ‘SubscriptingRef’
   94 | static void mysql_deparse_array_ref(SubscriptingRef *node, deparse_expr_cxt *context);
      |                                     ^~~~~~~~~~~~~~~
/home/cbe/projects/postgresql/mysql-fdw/postgresql-mysql-fdw/deparse.c: In function ‘deparseExpr’:
/home/cbe/projects/postgresql/mysql-fdw/postgresql-mysql-fdw/deparse.c:511:8: error: ‘T_SubscriptingRef’ undeclared (first use in this function)
  511 |   case T_SubscriptingRef:
      |        ^~~~~~~~~~~~~~~~~
mithuncy commented 4 years ago

Thanks! I just committed a patch to fix same.

df7cb commented 4 years ago

@mithuncy: We need a release.

mithuncy commented 4 years ago

Done under the same name deleted old ones!

df7cb commented 4 years ago

Don't do that. I had already imported the old 2.5.2 into the Debian git repository, and now it's a big mess because there's two tarballs with the same name. Please make a new release.

mithuncy commented 4 years ago

Okay! Bumped to a new version REL-2_5_3. Made a new release

df7cb commented 4 years ago

@mithuncy: Thanks! All Debian packages built fine now.

surajkharage19 commented 2 years ago

Hi,

Postgres 12 support is already added, hence closing this ticket.