search

EnterpriseDB / mysql_fdw

PostgreSQL foreign data wrapper for MySQL
Other
521 stars 160 forks source link

Catch output variation for recent MariaDB server changes #232

Open df7cb opened 2 years ago

df7cb commented 2 years ago

MariaDB 10.5 prints "Unknown server host" instead of "Unknown MySQL server host".

We are already normalizing the error message in tests, accept that form as well.

Regression diff observed was: -NOTICE: failed to connect to MySQL: Unknown MySQL server host 'localhos' +NOTICE: failed to connect to MySQL: Unknown server host 'localhos' (-2)

surajkharage19 commented 2 years ago

Hi,

Can you please share the exact MariaDB version? I checked on MariaDB 10.5.13 version and could not see the above regression diff.

df7cb commented 2 years ago

The string is from mariadb 10.5.12 there: https://sources.debian.org/src/mariadb-10.5/1:10.5.12-1/sql-common/errmsg.c/?hl=34#L34

Failing build log: https://pgdgbuild.dus.dg-i.net/job/postgresql-mysql-fdw-binaries/51/architecture=amd64,distribution=sid/consoleFull

surajkharage19 commented 2 years ago

I am not sure whether that error is version-specific or not because I am not able to see regression diff at my end against MariaDB 10.5.13 on CentOS 7. However, your suggested change make sense to me as your facing this issue at your end. We will take this forward. Thanks.