search

EnterpriseDB / mysql_fdw

PostgreSQL foreign data wrapper for MySQL
Other
521 stars 160 forks source link

Fix unstable ordering in sql/select test #254

Closed df7cb closed 11 months ago

df7cb commented 2 years ago

Several NULL values in the c7 column compare equal, sort by c1 to stabilize ordering.

Build log:

15:04:14 **** regression.diffs ****
15:04:14 --- /tmp/autopkgtest.vLTNig/tree/expected/select.out   2022-05-16 06:15:40.000000000 +0000
15:04:14 +++ /tmp/autopkgtest.vLTNig/tree/results/select.out    2022-05-20 13:04:11.206537285 +0000
15:04:14 @@ -1613,19 +1613,19 @@
15:04:14    c1  |  c2   |    c3     |  c4  |     c5     |     c6     |  c7  | c8 
15:04:14  ------+-------+-----------+------+------------+------------+------+----
15:04:14    100 | EMP1  | ADMIN     | 1300 | 1980-12-17 |  800.23000 |      | 20
15:04:14 -  400 | EMP4  | MANAGER   |  900 | 1981-04-02 | 2975.12000 |      | 20
15:04:14 -  600 | EMP6  | MANAGER   |  900 | 1981-05-01 | 2850.00000 |      | 30
15:04:14 -  700 | EMP7  | MANAGER   |  900 | 1981-06-09 | 2450.45000 |      | 10
15:04:14 -  800 | EMP8  | FINANCE   |  400 | 1987-04-19 | 3000.00000 |      | 20
15:04:14 -  900 | EMP9  | HEAD      |      | 1981-11-17 | 5000.00000 |      | 10
15:04:14 - 1100 | EMP11 | ADMIN     |  800 | 1987-05-23 | 1100.00000 |      | 20
15:04:14 - 1200 | EMP12 | ADMIN     |  600 | 1981-12-03 |  950.00000 |      | 30
15:04:14   1300 | EMP13 | FINANCE   |  400 | 1981-12-03 | 3000.00000 |      | 20
15:04:14 + 1200 | EMP12 | ADMIN     |  600 | 1981-12-03 |  950.00000 |      | 30
15:04:14 + 1100 | EMP11 | ADMIN     |  800 | 1987-05-23 | 1100.00000 |      | 20
15:04:14 +  900 | EMP9  | HEAD      |      | 1981-11-17 | 5000.00000 |      | 10
15:04:14 +  800 | EMP8  | FINANCE   |  400 | 1987-04-19 | 3000.00000 |      | 20
15:04:14 +  700 | EMP7  | MANAGER   |  900 | 1981-06-09 | 2450.45000 |      | 10
15:04:14 +  600 | EMP6  | MANAGER   |  900 | 1981-05-01 | 2850.00000 |      | 30
15:04:14 +  400 | EMP4  | MANAGER   |  900 | 1981-04-02 | 2975.12000 |      | 20
15:04:14   1400 | EMP14 | ADMIN     |  700 | 1982-01-23 | 1300.00000 |      | 10
15:04:14 -  200 | EMP2  | SALESMAN  |  600 | 1981-02-20 | 1600.00000 |  300 | 30
15:04:14 -  300 | EMP3  | SALESMAN  |  600 | 1981-02-22 | 1250.00000 |  500 | 30
15:04:14    500 | EMP5  | SALESMAN  |  600 | 1981-09-28 | 1250.00000 | 1400 | 30
15:04:14   1000 | EMP10 | SALESMAN  |  600 | 1980-09-08 | 1500.00000 |    0 | 30
15:04:14 +  300 | EMP3  | SALESMAN  |  600 | 1981-02-22 | 1250.00000 |  500 | 30
15:04:14 +  200 | EMP2  | SALESMAN  |  600 | 1981-02-20 | 1600.00000 |  300 | 30
15:04:14  (14 rows)
15:04:14  
15:04:14  -- Order by is not null desc
15:04:14 @@ -1646,14 +1646,14 @@
15:04:14    500 | EMP5  | SALESMAN  |  600 | 1981-09-28 | 1250.00000 | 1400 | 30
15:04:14   1000 | EMP10 | SALESMAN  |  600 | 1980-09-08 | 1500.00000 |    0 | 30
15:04:14    100 | EMP1  | ADMIN     | 1300 | 1980-12-17 |  800.23000 |      | 20
15:04:14 -  400 | EMP4  | MANAGER   |  900 | 1981-04-02 | 2975.12000 |      | 20
15:04:14 -  600 | EMP6  | MANAGER   |  900 | 1981-05-01 | 2850.00000 |      | 30
15:04:14 -  700 | EMP7  | MANAGER   |  900 | 1981-06-09 | 2450.45000 |      | 10
15:04:14 -  800 | EMP8  | FINANCE   |  400 | 1987-04-19 | 3000.00000 |      | 20
15:04:14 -  900 | EMP9  | HEAD      |      | 1981-11-17 | 5000.00000 |      | 10
15:04:14 - 1100 | EMP11 | ADMIN     |  800 | 1987-05-23 | 1100.00000 |      | 20
15:04:14 - 1200 | EMP12 | ADMIN     |  600 | 1981-12-03 |  950.00000 |      | 30
15:04:14   1300 | EMP13 | FINANCE   |  400 | 1981-12-03 | 3000.00000 |      | 20
15:04:14 + 1200 | EMP12 | ADMIN     |  600 | 1981-12-03 |  950.00000 |      | 30
15:04:14 + 1100 | EMP11 | ADMIN     |  800 | 1987-05-23 | 1100.00000 |      | 20
15:04:14 +  900 | EMP9  | HEAD      |      | 1981-11-17 | 5000.00000 |      | 10
15:04:14 +  800 | EMP8  | FINANCE   |  400 | 1987-04-19 | 3000.00000 |      | 20
15:04:14 +  700 | EMP7  | MANAGER   |  900 | 1981-06-09 | 2450.45000 |      | 10
15:04:14 +  600 | EMP6  | MANAGER   |  900 | 1981-05-01 | 2850.00000 |      | 30
15:04:14 +  400 | EMP4  | MANAGER   |  900 | 1981-04-02 | 2975.12000 |      | 20
15:04:14   1400 | EMP14 | ADMIN     |  700 | 1982-01-23 | 1300.00000 |      | 10
15:04:14  (14 rows)
15:04:14  
15:04:14 @@ -1671,14 +1671,14 @@
15:04:14    c1  |  c2   |    c3     |  c4  |     c5     |     c6     |  c7  | c8 
15:04:14  ------+-------+-----------+------+------------+------------+------+----
15:04:14    100 | EMP1  | ADMIN     | 1300 | 1980-12-17 |  800.23000 |      | 20
15:04:14 -  400 | EMP4  | MANAGER   |  900 | 1981-04-02 | 2975.12000 |      | 20
15:04:14 -  600 | EMP6  | MANAGER   |  900 | 1981-05-01 | 2850.00000 |      | 30
15:04:14 -  700 | EMP7  | MANAGER   |  900 | 1981-06-09 | 2450.45000 |      | 10
15:04:14 -  800 | EMP8  | FINANCE   |  400 | 1987-04-19 | 3000.00000 |      | 20
15:04:14 -  900 | EMP9  | HEAD      |      | 1981-11-17 | 5000.00000 |      | 10
15:04:14 - 1100 | EMP11 | ADMIN     |  800 | 1987-05-23 | 1100.00000 |      | 20
15:04:14 - 1200 | EMP12 | ADMIN     |  600 | 1981-12-03 |  950.00000 |      | 30
15:04:14   1300 | EMP13 | FINANCE   |  400 | 1981-12-03 | 3000.00000 |      | 20
15:04:14 + 1200 | EMP12 | ADMIN     |  600 | 1981-12-03 |  950.00000 |      | 30
15:04:14 + 1100 | EMP11 | ADMIN     |  800 | 1987-05-23 | 1100.00000 |      | 20
15:04:14 +  900 | EMP9  | HEAD      |      | 1981-11-17 | 5000.00000 |      | 10
15:04:14 +  800 | EMP8  | FINANCE   |  400 | 1987-04-19 | 3000.00000 |      | 20
15:04:14 +  700 | EMP7  | MANAGER   |  900 | 1981-06-09 | 2450.45000 |      | 10
15:04:14 +  600 | EMP6  | MANAGER   |  900 | 1981-05-01 | 2850.00000 |      | 30
15:04:14 +  400 | EMP4  | MANAGER   |  900 | 1981-04-02 | 2975.12000 |      | 20
15:04:14   1400 | EMP14 | ADMIN     |  700 | 1982-01-23 | 1300.00000 |      | 10
15:04:14    500 | EMP5  | SALESMAN  |  600 | 1981-09-28 | 1250.00000 | 1400 | 30
15:04:14    300 | EMP3  | SALESMAN  |  600 | 1981-02-22 | 1250.00000 |  500 | 30
15:04:14 @@ -1704,14 +1704,14 @@
15:04:14    200 | EMP2  | SALESMAN  |  600 | 1981-02-20 | 1600.00000 |  300 | 30
15:04:14   1000 | EMP10 | SALESMAN  |  600 | 1980-09-08 | 1500.00000 |    0 | 30
15:04:14    100 | EMP1  | ADMIN     | 1300 | 1980-12-17 |  800.23000 |      | 20
15:04:14 -  400 | EMP4  | MANAGER   |  900 | 1981-04-02 | 2975.12000 |      | 20
15:04:14 -  600 | EMP6  | MANAGER   |  900 | 1981-05-01 | 2850.00000 |      | 30
15:04:14 -  700 | EMP7  | MANAGER   |  900 | 1981-06-09 | 2450.45000 |      | 10
15:04:14 -  800 | EMP8  | FINANCE   |  400 | 1987-04-19 | 3000.00000 |      | 20
15:04:14 -  900 | EMP9  | HEAD      |      | 1981-11-17 | 5000.00000 |      | 10
15:04:14 - 1100 | EMP11 | ADMIN     |  800 | 1987-05-23 | 1100.00000 |      | 20
15:04:14 - 1200 | EMP12 | ADMIN     |  600 | 1981-12-03 |  950.00000 |      | 30
15:04:14   1300 | EMP13 | FINANCE   |  400 | 1981-12-03 | 3000.00000 |      | 20
15:04:14 + 1200 | EMP12 | ADMIN     |  600 | 1981-12-03 |  950.00000 |      | 30
15:04:14 + 1100 | EMP11 | ADMIN     |  800 | 1987-05-23 | 1100.00000 |      | 20
15:04:14 +  900 | EMP9  | HEAD      |      | 1981-11-17 | 5000.00000 |      | 10
15:04:14 +  800 | EMP8  | FINANCE   |  400 | 1987-04-19 | 3000.00000 |      | 20
15:04:14 +  700 | EMP7  | MANAGER   |  900 | 1981-06-09 | 2450.45000 |      | 10
15:04:14 +  600 | EMP6  | MANAGER   |  900 | 1981-05-01 | 2850.00000 |      | 30
15:04:14 +  400 | EMP4  | MANAGER   |  900 | 1981-04-02 | 2975.12000 |      | 20
15:04:14   1400 | EMP14 | ADMIN     |  700 | 1982-01-23 | 1300.00000 |      | 10
15:04:14  (14 rows)
15:04:14  
15:04:14
jeevanchalke commented 11 months ago

Committed. So closing the request.