EnterpriseDB / mysql_fdw

PostgreSQL foreign data wrapper for MySQL
Other
521 stars 160 forks source link

Regression tests fail with PG 10+11 #261

Open df7cb opened 1 year ago

df7cb commented 1 year ago

PostgreSQL 10 on Ubuntu Jammy:

17:10:59 --- /tmp/autopkgtest.I0N6ZP/tree/expected/pushdown.out 2022-12-14 07:09:45.000000000 +0000
17:10:59 +++ /tmp/autopkgtest.I0N6ZP/tree/results/pushdown.out  2022-12-16 16:10:58.549828251 +0000
17:10:59 @@ -565,20 +565,16 @@
17:10:59  
17:10:59  EXPLAIN (COSTS FALSE, VERBOSE)
17:10:59  SELECT MIN(c1) FROM f_test_tbl1 ORDER BY 1 USING OPERATOR(public.<^);
17:10:59 -                                                                QUERY PLAN                                                                 
17:10:59 --------------------------------------------------------------------------------------------------------------------------------------------
17:10:59 +                                 QUERY PLAN                                  
17:10:59 +-----------------------------------------------------------------------------
17:10:59   Sort
17:10:59 -   Output: ($0)
17:10:59 -   Sort Key: ($0) USING <^
17:10:59 -   InitPlan 1 (returns $0)
17:10:59 -     ->  Limit
17:10:59 -           Output: f_test_tbl1.c1
17:10:59 -           ->  Foreign Scan on public.f_test_tbl1
17:10:59 -                 Output: f_test_tbl1.c1
17:10:59 -                 Remote query: SELECT `c1` FROM `mysql_fdw_regress`.`test_tbl1` WHERE ((`c1` IS NOT NULL)) ORDER BY `c1` IS NULL, `c1` ASC
17:10:59 -   ->  Result
17:10:59 -         Output: $0
17:10:59 -(11 rows)
17:10:59 +   Output: (min(c1))
17:10:59 +   Sort Key: (min(f_test_tbl1.c1)) USING <^
17:10:59 +   ->  Foreign Scan
17:10:59 +         Output: (min(c1))
17:10:59 +         Relations: Aggregate on (mysql_fdw_regress.f_test_tbl1)
17:10:59 +         Remote query: SELECT min(`c1`) FROM `mysql_fdw_regress`.`test_tbl1`
17:10:59 +(7 rows)
17:10:59  
17:10:59  -- Cleanup
17:10:59  DELETE FROM f_test_tbl1;
17:10:59 

https://pgdgbuild.dus.dg-i.net/job/postgresql-mysql-fdw-binaries/64/architecture=amd64,distribution=jammy/console#console-section-15

surajkharage19 commented 1 year ago

Hi,

I am not able to reproduce this issue on CentOS platform, this seems specific to Ubuntu. Since v10 is EOL and we are not generating packages for the same, it is not worth fixing the out file.

df7cb commented 1 year ago

Then I suggest dropping PG10 from the list of supported versions in the README file.

surajkharage19 commented 1 year ago

Yes, we are planning to remove v10 support in the next release as the current release is already out.

df7cb commented 1 year ago

Actually the problem is present in PG11 as well. (Haven't tried later releases yet, the build stops here.)

11:30:46 Dropping cluster 11/regress ...
11:30:46 **** regression.diffs ****
11:30:46 --- /tmp/autopkgtest.2IWtxj/tree/expected/pushdown.out 2022-12-14 07:09:45.000000000 +0000
11:30:46 +++ /tmp/autopkgtest.2IWtxj/tree/results/pushdown.out  2023-02-03 10:30:45.893445928 +0000
11:30:46 @@ -565,20 +565,16 @@
11:30:46  
11:30:46  EXPLAIN (COSTS FALSE, VERBOSE)
11:30:46  SELECT MIN(c1) FROM f_test_tbl1 ORDER BY 1 USING OPERATOR(public.<^);
11:30:46 -                                                                QUERY PLAN                                                                 
11:30:46 --------------------------------------------------------------------------------------------------------------------------------------------
11:30:46 +                                 QUERY PLAN                                  
11:30:46 +-----------------------------------------------------------------------------
11:30:46   Sort
11:30:46 -   Output: ($0)
11:30:46 -   Sort Key: ($0) USING <^
11:30:46 -   InitPlan 1 (returns $0)
11:30:46 -     ->  Limit
11:30:46 -           Output: f_test_tbl1.c1
11:30:46 -           ->  Foreign Scan on public.f_test_tbl1
11:30:46 -                 Output: f_test_tbl1.c1
11:30:46 -                 Remote query: SELECT `c1` FROM `mysql_fdw_regress`.`test_tbl1` WHERE ((`c1` IS NOT NULL)) ORDER BY `c1` IS NULL, `c1` ASC
11:30:46 -   ->  Result
11:30:46 -         Output: $0
11:30:46 -(11 rows)
11:30:46 +   Output: (min(c1))
11:30:46 +   Sort Key: (min(f_test_tbl1.c1)) USING <^
11:30:46 +   ->  Foreign Scan
11:30:46 +         Output: (min(c1))
11:30:46 +         Relations: Aggregate on (mysql_fdw_regress.f_test_tbl1)
11:30:46 +         Remote query: SELECT min(`c1`) FROM `mysql_fdw_regress`.`test_tbl1`
11:30:46 +(7 rows)
11:30:46  
11:30:46  -- Cleanup
11:30:46  DELETE FROM f_test_tbl1;
11:30:46 
11:30:46 ======================================================================
11:30:46 
11:30:46 ### End 11 installcheck (FAILED with exit code 1) ###

From a packager perspective, please make sure to run the tests before releasing. Thanks!