Closed m-raafat-abdelkader closed 1 year ago
Please add the line ends in (your change is all on one big long line at the moment), and I think this is good to go.
Done.
Line 52: will not be removed when you run DROP EXTENSION This means that any users or roles that were granted permissions to the monitor_system_stats role will still have those permissions even after the extension has been dropped.
I don't see that change in the PR.
I've made that change as my last commit https://github.com/EnterpriseDB/system_stats/pull/8/commits/dbeec0da47615752bcbae274ecd1570d2a164be3
No, the line breaks have not been fixed; see https://github.com/EnterpriseDB/system_stats/pull/8/commits/dbeec0da47615752bcbae274ecd1570d2a164be3.
Changes I've added are on line 51 ("When you run DROP EXTENSION. This means........ dropped."). Hope that fixed the line breaks.
I'm not sure we're looking at the same thing. Please see the screenshot below; the text should hard-wrap before column 80, as the rest of the file does.:
Done. I've made that change https://github.com/EnterpriseDB/system_stats/pull/8/commits/0deda2b01e34eaa3b41c6459645a91ddb369afac following the 80-column rule. Thanks a lot for your patience. @dpage
Committed - thanks!
@dpage