EnterpriseDB / system_stats

A Postgres extension for exposing system metrics such as CPU, memory and disk information
Other
111 stars 24 forks source link

Update README.md #8

Closed m-raafat-abdelkader closed 1 year ago

m-raafat-abdelkader commented 1 year ago

@dpage

dpage commented 1 year ago

Please add the line ends in (your change is all on one big long line at the moment), and I think this is good to go.

m-raafat-abdelkader commented 1 year ago

Done.

Line 52: will not be removed when you run DROP EXTENSION This means that any users or roles that were granted permissions to the monitor_system_stats role will still have those permissions even after the extension has been dropped.

dpage commented 1 year ago

I don't see that change in the PR.

m-raafat-abdelkader commented 1 year ago

I've made that change as my last commit https://github.com/EnterpriseDB/system_stats/pull/8/commits/dbeec0da47615752bcbae274ecd1570d2a164be3

dpage commented 1 year ago

No, the line breaks have not been fixed; see https://github.com/EnterpriseDB/system_stats/pull/8/commits/dbeec0da47615752bcbae274ecd1570d2a164be3.

m-raafat-abdelkader commented 1 year ago

Changes I've added are on line 51 ("When you run DROP EXTENSION. This means........ dropped."). Hope that fixed the line breaks.

dpage commented 1 year ago

I'm not sure we're looking at the same thing. Please see the screenshot below; the text should hard-wrap before column 80, as the rest of the file does.:

Screenshot 2023-03-29 at 12 40 28

m-raafat-abdelkader commented 1 year ago

Done. I've made that change https://github.com/EnterpriseDB/system_stats/pull/8/commits/0deda2b01e34eaa3b41c6459645a91ddb369afac following the 80-column rule. Thanks a lot for your patience. @dpage

dpage-edb commented 1 year ago

Committed - thanks!