search

EnterpriseLibrary / logging-application-block

Apache License 2.0
1 stars 9 forks source link

An empty (0b) archive log files are being created #7

Open vash6p opened 2 years ago

vash6p commented 2 years ago

The RollingFlatFileTraceListener is saving empty (0b) archive log files, while performing roll. I've prepared an improvement/fix for this issue - an additional option to indicate whether to create an archive file even if it would be empty. The default value is "Always create", so the default behavior will not change. @Chavoshi I'd be great if I could commit it and present in PR.

The funny thing is, the code regarding this functionality in the original .NET version of this library seems identical, yet empty archive files are not created, which I believe I desired for this implementation. :)

Chavoshi commented 2 years ago

Hi @vash6p, Any contribution is appreciated. Thanks,

vash6p commented 2 years ago

Great, @Chavoshi Please then grant me permission to push into repository. Currently, I'm getting

Permission to EnterpriseLibrary/logging-application-block.git denied to vash6p.

when trying to push my branch.

Chavoshi commented 2 years ago

@vash6p , Please Fork the project and send a Pull Request?