search

EnterpriseQualityCoding / FizzBuzzEnterpriseEdition

FizzBuzz Enterprise Edition is a no-nonsense implementation of FizzBuzz made by serious businessmen for serious business purposes.
21.45k stars 757 forks source link

Enabling Checkstyle #229

Open adaofeliz opened 9 years ago

adaofeliz commented 9 years ago

I'm not sure how can this happen, but just noticed that this project does not have checkstyle enabled. The steering group should define all rules and validate them with this guy: http://imgur.com/HWWqkd5 I can help if needed: https://pbs.twimg.com/media/CJX1RljWcAAGf0W.png

mkeathley commented 9 years ago

Could we refrain from using image sharing sites for proprietary information? Use sharepoint instead.

On Tue, Oct 6, 2015 at 11:49 PM, Adao Feliz notifications@github.com wrote:

I'm not sure how can this happen, but just noticed that this project does not have checkstyle enabled. The steering group should define all rules and validate them with this guy: http://imgur.com/HWWqkd5 I can help if needed: https://pbs.twimg.com/media/CJX1RljWcAAGf0W.png

— Reply to this email directly or view it on GitHub https://github.com/EnterpriseQualityCoding/FizzBuzzEnterpriseEdition/issues/229 .

emiln commented 9 years ago

I think this is an excellent idea. In fact I think we should at the very least require that pull requests pass all of Checkstyle, PMD, and FindBugs before being merged into our master branch. This will ensure the pristine level of Enterprise quality coding this project is known for. I will contact DevOps immediately to have them implement this.