EnterpriseyIntranet / nextcloud-API

NextCloud OCS API for Python

GNU General Public License v3.0

27 stars 27 forks source link

PyPi #28

Closed danil-topchiy closed 5 years ago

scrutinizer-notifier commented 5 years ago

The inspection completed: 1 updated code elements

codecov-io commented 5 years ago

Codecov Report

Merging #28 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   93.77%   93.77%           
=======================================
  Files          17       17           
  Lines         466      466           
=======================================
  Hits          437      437           
  Misses         29       29

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ffed39...c1da93e. Read the comment docs.

matejak commented 5 years ago

This looks good so far. I know that it is WIP, but I will have one remark about long description - Python projects often embed their READMEs, so the description is not duplicated.

danil-topchiy commented 5 years ago

@matejak thanks, I will embed README. Could you also suggest if I need to add anything else for this PR?

matejak commented 5 years ago

Looks good. Did you rebase, or was the embedding of README there from the beginning?

Anyway, merging - details s.a. version handling can be added later.

danil-topchiy commented 5 years ago

It was from the beginning

matejak commented 5 years ago

OK Then my comment didn't make sense :-) I must have still been hazy at that time.