NextCloudConnectionError exception

EnterpriseyIntranet / nextcloud-API

NextCloud OCS API for Python

GNU General Public License v3.0

27 stars 27 forks source link

Closed danil-topchiy closed 5 years ago

danil-topchiy commented 5 years ago

add NextCloudConnectionError on connection errors during request to nextcloud

scrutinizer-notifier commented 5 years ago

The inspection completed: 2 new issues, 1 updated code elements

matejak commented 5 years ago

Hello, it works great, I have just two remarks:

Why not to pass the urllib message through - there may be a difference between unknown host, connection rejected and TCP timeout.
It would be great to include the URL in the error message - some use cases may involve incorrect data to be supplied as the URL, and this would help to quickly debug it.
Could you make a test for the invalid URL case? This should be fairly simple.

matejak commented 5 years ago

Could you please make a follow-up PR? I was in merging mood today :-)