Fix and modification of "download_file"

EnterpriseyIntranet / nextcloud-API

NextCloud OCS API for Python

GNU General Public License v3.0

27 stars 27 forks source link

Fix and modification of "download_file" #63

Open solanav opened 3 years ago

solanav commented 3 years ago

There was an error when downloading text files on f.write(res.data) in webdav.py:

TypeError: a bytes-like object is required, not 'str'

I also added a two new parameters to this function:

download_path (str): to specify where you want to download the file instead of assuming "./"
overwrite (bool): to choose if you want to overwrite files or you want to raise an exception on duplicate files.

scrutinizer-notifier commented 3 years ago

The inspection completed: 1 new issues, 1 updated code elements

luffah commented 3 years ago

( If you still have the test case, i ll be grateful if you test with my repo — refactored code and python2 compat — : https://github.com/luffah/nextcloud-API )