search

Enterwell / Wpf.Notifications

WPF notifications UI controls (as seen in VS Code)
MIT License
394 stars 39 forks source link

Feature: .NET Core / .NET 5 compatibility #29

Open Deadpikle opened 3 years ago

Deadpikle commented 3 years ago

It's been a few years. Hi again!

This PR adds compatibility with .NET Core and the newly released .NET 5. It also moves the main csproj file to an SDK-style project. A .NET 4.5.1 build output is still created. I also added a .NET 5 sample for a proof of concept that uses the latest version of MahApps.Metro (2.3.4 as of this writing).

All that would need to be done after merging this is bumping the version (in the .csproj now) and updating the NuGet.

One way to easy-mode make a NuGet package is to right click the csproj -> Properties -> Package -> check the 'Generate NuGet package on build' checkbox. Then it'll take care of a bunch of annoying details for you.

@AleksandarDev Any chance we could have an updated NuGet when/if this is merged? Thanks! :)

MarcoSpoenemann commented 3 years ago

Any news on this topic?

Deadpikle commented 3 years ago

@AleksandarDev ?

CyLuGh commented 3 years ago

Thanks for your work on a .NET Core / 5 version! Shouldn't it become a fork of this project, seeing that there haven't been updates for quite a while now?